Closed
Bug 1069476
Opened 10 years ago
Closed 10 years ago
Usage first time use: Data usage limit: limit unit drop down is not accessible
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S6 (20feb)
People
(Reporter: yzen, Assigned: yzen)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1][NaBfT])
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
mai
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
Steps to reproduce (with screen reader): * Open usage app (for the first time) * Navigate to Data usage limit page by activating Next button twice * Try to focus on the uni drop down at the bottom / Try to swipe to the unit drop down at the bottom ** Expected: the screen reader can focus on the drop down and activate it ** Observed: the screen reader can't focus on the drop down.
Updated•10 years ago
|
Whiteboard: [b2ga11y p=1] → [b2ga11y p=1][NaBfT]
Comment 1•10 years ago
|
||
As it currently stands, the unit widget is a button, pressing it toggles between GB and MB by changing the label. I think this will actually work if we listen for accessible name change events in AccessFu.
Updated•10 years ago
|
Assignee: nobody → eitan
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Assignee: eitan → yzenevich
Comment 2•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8559906 -
Flags: review?(salva)
Comment 3•10 years ago
|
||
Comment on attachment 8559906 [details] [review] [PullReq] yzen:bug-1069476 to mozilla-b2g:master Marina, can you take a look at this bug, please? Thank you.
Attachment #8559906 -
Flags: review?(salva) → review?(marina.rodrigueziglesias)
Comment 4•10 years ago
|
||
Comment on attachment 8559906 [details] [review] [PullReq] yzen:bug-1069476 to mozilla-b2g:master Hi, LGTM, only a few nits on github. Although, the bug only refers to the fte, would you mind apply the same corrections to the datalimit section on settings? Regards, Marina
Attachment #8559906 -
Flags: review?(marina.rodrigueziglesias)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8559906 [details] [review] [PullReq] yzen:bug-1069476 to mozilla-b2g:master Took care of the comments, thanks!
Attachment #8559906 -
Flags: review?(marina.rodrigueziglesias)
Comment 6•10 years ago
|
||
Comment on attachment 8559906 [details] [review] [PullReq] yzen:bug-1069476 to mozilla-b2g:master Great work, Thanks r+
Attachment #8559906 -
Flags: review?(marina.rodrigueziglesias) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/e3209d84804614dae15089c46c271f54ce1843c5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8559906 [details] [review] [PullReq] yzen:bug-1069476 to mozilla-b2g:master [Approval Request Comment] Making usage unit selection more accessible to the screen reader [Bug caused by] (feature/regressing bug #): improvement, not a bug [User impact] if declined: If declined, the screen reader user will have a poor experience when setting the usage units and limits. [Testing completed]: Manual on device and unit tests [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: https://github.com/mozilla-b2g/gaia/pull/27978/files#diff-e1b739d2c9ec9f01cd2a61e729bfcd03
Attachment #8559906 -
Flags: approval-gaia-v2.2?
Updated•10 years ago
|
Attachment #8559906 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 9•10 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/85b7502b4418c398ddc9447bf36e58dc3a36c042
You need to log in
before you can comment on or make changes to this bug.
Description
•