1069818 - Sometimes, in the waterfall, markers are not sorted properly

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Paul Rouget [:paul]]

Attachment: screenshot

For any markers in the timeline, any marker starting earlier than another marker should be displayed before the other marker.

But apparently, sometimes, it doesn't happen.

Comment 1

[Victor Porof [:vporof][:vp]]

I guess the markers we receive aren't always consecutive, time-wise. That's okay, we can defer this sorting, but Paul, do you have an explanation for that?

Comment 2

[Paul Rouget [:paul]]

(In reply to Victor Porof [:vporof][:vp] from comment #1)
> I guess the markers we receive aren't always consecutive, time-wise. That's
> okay, we can defer this sorting, but Paul, do you have an explanation for
> that?

I don't. Markers are added, sorted and poped synchronously. Weird. Patrick?

Comment 3

[Tom Tromey :tromey]

On irc we discussed it and the hypothesis is that this is bug 1070089

Comment 4

[Patrick Brosset <:pbro>]

(In reply to Tom Tromey :tromey from comment #3)
> On irc we discussed it and the hypothesis is that this is bug 1070089
Yeah, this looks like it's the issue for sure. Each docShell has its own mProfileTimelineStartTime member which is set to the time the recording started for that docShell. So when we record nested iframes too, they're going to have their own start times.

Comment 5

[Tom Tromey :tromey]

I think this was fixed when bug 1070089 was fixed.

Comment 6

[David Lawrence [:dkl]]

Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl