Closed Bug 1069974 Opened 8 years ago Closed 8 years ago

[Contacts] [ICE] Deleting ICE Contact 1 makes ICE Contact 2 to promote to position 1

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 verified, b2g-v2.2 verified)

VERIFIED FIXED
2.1 S5 (26sep)
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: jmcf, Assigned: jmcf)

Details

Attachments

(1 file)

STR:

Set ICE Contact 1 and ICE Contact 2

Remove ICE Contact 2.

Go to Settings / ICE Contacts. ICE Contact 2 now appears in position 1
Carrie,

I think this is not the intended behaviour. I mean, ICE Contact 2 should remain in position 2 and not "promote" to position 1.

Please confirm

thanks
Flags: needinfo?(cawang)
Hi Jose, 

Yes, the expected behavior is remaining ICE 2 in position 2. Looks like it's a bug here. Thanks!
Flags: needinfo?(cawang)
Attached file 24330.html
Attachment #8493675 - Flags: review?(francisco)
Target Milestone: --- → 2.1 S5 (26sep)
QA Whiteboard: [ICE]
Comment on attachment 8493675 [details]
24330.html

Let's keep the code based on promises, instead of callbacks passing. That will increase readability and will prevent us for having to check for callback existence and type.

Apart from that, the code for manipulating the data state is perfect.
Attachment #8493675 - Flags: review?(francisco) → review-
Attachment #8493675 - Flags: review- → review?(francisco)
Comment on attachment 8493675 [details]
24330.html

Great patch here!
Attachment #8493675 - Flags: review?(francisco) → review+
landed in master:

https://github.com/mozilla-b2g/gaia/commit/84c9fcb8c846203ede478c05886ef9fff9384f79
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8493675 [details]
24330.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: it is confusing when you set a contact as two and it is converted to first ICE contact
[Testing completed]: added unit test and manually by developer
[Risk to taking this patch] (and alternatives if risky): close to null
[String changes made]: no
Attachment #8493675 - Flags: approval-gaia-v2.1?
Tested and working
Flame
Eng
Gecko-a310d15
Gaia-931d547

Pending 2.1
Attachment #8493675 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Needs rebasing for v2.1 uplift.
Flags: needinfo?(jmcf)
Keywords: verifyme
Tested and working
2.1
Flame
User
Platform versin: 34.0a2
Build ID: 20141002015226
Git commit: c1cc61e3
Status: RESOLVED → VERIFIED
No longer blocks: 1071632
Issue is verified fixed on flame 2.2 and flame 2.1

When removing the second ICE contact, that contact does not move up to ICE contact 1.

Flame 2.2
Environmental Variables:
Device: Flame 2.2
Build ID: 20141125040209
Gaia: 824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko: acde07cb4e4d
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141125001201
Gaia: 1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko: db893274d9a6
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
QA Whiteboard: [ICE] → [ICE] [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [ICE] [QAnalyst-Triage?] → [ICE] [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.