1069974 - [Contacts] [ICE] Deleting ICE Contact 1 makes ICE Contact 2 to promote to position 1

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

STR:

Set ICE Contact 1 and ICE Contact 2

Remove ICE Contact 2.

Go to Settings / ICE Contacts. ICE Contact 2 now appears in position 1

Comment 1

[Jose Manuel Cantera]

Carrie,

I think this is not the intended behaviour. I mean, ICE Contact 2 should remain in position 2 and not "promote" to position 1.

Please confirm

thanks

Comment 2

[Carrie Wang [New account: [e-mail]]]

Hi Jose, 

Yes, the expected behavior is remaining ICE 2 in position 2. Looks like it's a bug here. Thanks!

Comment 3

[Jose Manuel Cantera]

Attachment: 24330.html

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8493675 [details]
24330.html

Let's keep the code based on promises, instead of callbacks passing. That will increase readability and will prevent us for having to check for callback existence and type.

Apart from that, the code for manipulating the data state is perfect.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8493675 [details]
24330.html

Great patch here!

Comment 6

[Jose Manuel Cantera]

landed in master:

https://github.com/mozilla-b2g/gaia/commit/84c9fcb8c846203ede478c05886ef9fff9384f79

Comment 7

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8493675 [details]
24330.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: it is confusing when you set a contact as two and it is converted to first ICE contact
[Testing completed]: added unit test and manually by developer
[Risk to taking this patch] (and alternatives if risky): close to null
[String changes made]: no

Comment 8

[Loli (:lolimartinezcr)]

Tested and working
Flame
Eng
Gecko-a310d15
Gaia-931d547

Pending 2.1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.1 uplift.

Comment 10

[Jose Manuel Cantera]

landed in v2.1

https://github.com/mozilla-b2g/gaia/commit/997e37faa5433c8ab8e4e5a33f518890d0900682

Comment 11

[Loli (:lolimartinezcr)]

Tested and working
2.1
Flame
User
Platform versin: 34.0a2
Build ID: 20141002015226
Git commit: c1cc61e3

Comment 12

[[:RJ]]

Issue is verified fixed on flame 2.2 and flame 2.1

When removing the second ICE contact, that contact does not move up to ICE contact 1.

Flame 2.2
Environmental Variables:
Device: Flame 2.2
Build ID: 20141125040209
Gaia: 824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko: acde07cb4e4d
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141125001201
Gaia: 1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko: db893274d9a6
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0