1070045 - Use of ES6 syntax breaks component showcase

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Andrei Oprea [:andreio]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20140915204924

Steps to reproduce:

In latest fx-team open the ui-showcase.


Actual results:

The page is broken because required files are not included & they use ES6 syntax which requires <script type="application/javascript;version=1.7"> [0] to support "let, const" etc. 

[0] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let


Expected results:

Loop components should show up

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

As discussed at standup today, we want a regression tests for this so that if the ui-showcase completely fails to load, the automated tests flag it.

It probably wants to be something very much like <https://github.com/mozilla/gecko-dev/blob/master/browser/components/loop/test/shared/frontend_tester.py>.  Perhaps that code could be refactored/overridden (i.e. check_page and get_failure details) to be slightly more generic.

Comment 2

[Matthew N. [:MattN]]

Attachment: WIP 1

I'm not actively working on this since I'm not very familiar with this code but this at lets more than a white page appear. There are still errors in the console.

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: shim contacts React classes when ES6 is not available in the browser used

I just took it all the way...

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8493642 [details] [diff] [review]
Patch v1: shim contacts React classes when ES6 is not available in the browser used

Review of attachment 8493642 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Mike de Boer [:mikedeboer]]

Thanks for the super-fast review!

Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/121504802da7

Comment 6

[Marco Mucci [:MarcoM]]

Added to IT 35.2

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Adding leave-open, as this still needs the regression test described in comment 1.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/121504802da7

Comment 9

[Paul Kerr [:pkerr]]

Taking up regression testing issue that was left open.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8493642 [details] [diff] [review]
Patch v1: shim contacts React classes when ES6 is not available in the browser used

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5b1cf6f6d72e

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8493642 [details] [diff] [review]
Patch v1: shim contacts React classes when ES6 is not available in the browser used

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.

Comment 13

[Maire Reavy [:mreavy]]

Opened bug 1088006 for the regression test.

Comment 14

[Mark Banner (:standard8)]

Tests were added in bug 1088006.