1088006 - Regression Test for "Use of ES6 syntax breaks component showcase"

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Maire Reavy [:mreavy]]

+++ This bug was initially created as a clone of Bug #1070045 +++

We want to add a regression test for Bug 1070045
https://bugzilla.mozilla.org/show_bug.cgi?id=1070045#c7

Comment 1

[Mark Banner (:standard8)]

We've wanted this or something along these lines for a while, and I've got a partial patch in progress somewhere, so taking.

Comment 2

[Mark Banner (:standard8)]

Attachment: Hook up Loop's ui-showcase to unit tests so that we don't keep on breaking it, and so that it can possibly catch use of es6 errors.

Having just hit this again, Dan talked me into finishing this patch off.

Here it is. We use the same structure as our unit tests so that we can use the Marionette harness. I've tested the failure modes by backing out the various parts of https://hg.mozilla.org/integration/fx-team/rev/c4d7c9f94f61 and checking the error output.

It works for me locally, but I'll push it to try before

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8576197 [details] [diff] [review]
Hook up Loop's ui-showcase to unit tests so that we don't keep on breaking it, and so that it can possibly catch use of es6 errors.

Review of attachment 8576197 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=dmose

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/901d9d1beec0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/901d9d1beec0