1070061 - "flash.sh time" fails because of wrong toolbox date syntax

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Marek Antoži]

Attachment: Patch to fix incorect adb toolbox date syntax used in flash.sh

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140830210550

Steps to reproduce:

cd B2G
./flash.sh time


Actual results:

Attempting to set the time on the device
time 1411149690 -> 1411149690.0
settimeofday failed Invalid argument



Expected results:

Attempting to set the time on the device
Fri Sep 19 20:06:03 CEST 2014

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8492294 [details] [diff] [review]
Patch to fix incorect adb toolbox date syntax used in flash.sh

This has been broken for as long as I can remember. Michael, I gave a spin to the patch and it seems to work fine on my Flame.

Comment 3

[Michael Wu [:mwu]]

Any idea if this works on ICS devices? I remember this broke after ICS.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Michael Wu [:mwu] from comment #3)
> Any idea if this works on ICS devices? I remember this broke after ICS.

Good point, I don't have an ICS device with me right now but I should be able to check next week. Worst case we can put both forms; only one should succeed anyway.

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: bug-1070061-flash-time.patch

This tries to set the time first using the older sytanx and then the new one if the older failed. I've tested it on the Keon (where only the old syntax works), the Hamachi (where both work) and the Flame (where only the newer one works).

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 8568549 [details] [diff] [review]
bug-1070061-flash-time.patch

Perfect - thanks for checking.

Comment 7

[Gabriele Svelto [:gsvelto] (PTO)]

Thanks for the review! Landed in B2G/master 57cc0d7427f666c5499eb6f7e72dbf9e88f7a605

https://github.com/mozilla-b2g/B2G/commit/57cc0d7427f666c5499eb6f7e72dbf9e88f7a605