Closed Bug 1070860 Opened 10 years ago Closed 10 years ago

[Loop] Wrong message if user try to make a call and is not logged-in

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mbarone976, Assigned: arnau)

References

Details

(Whiteboard: [mobile app][blocking][tef-triage][patch available])

Attachments

(3 files)

2014-09-22-10-10-37.png
24.66 KB, image/png
Details
Prompt
247.03 KB, image/png
Details
patch in github
61 bytes, text/x-github-pull-request
borjasalguero
: review+
Details | Review
Attached image 2014-09-22-10-10-37.png —
STR 1. Intall Loop App 2. From contact app, make a call to a valid Loop ID user ACTUAL RESULT The warning message is "You need to be logged in before making a call with Loop" EXPECTED RESULT Loop should be not present in the warning message
OS: All → Gonk (Firefox OS)
Hardware: x86 → ARM
I suppose that we need to say "You need to be logged in before making a call with Firefox Hello" Pau, Rafa, can you confirm it, please?
Flags: needinfo?(hello)
Flags: needinfo?(b.pmm)
Assignee: nobody → rnowmrch
Status: NEW → ASSIGNED
A little tweak: "You need to be logged in to use Firefox Hello". Nice-to-have: Two buttons below => [Ok] [Log in] Obviously the latter takes the user to the app.
Flags: needinfo?(hello)
Attached image Prompt —
It should be like this, then :)
Flags: needinfo?(b.pmm)
Arnau, if including the screen with the two buttons is complex, let's fix the string issue only in this bug that's the important one.
Severity: minor → major
Whiteboard: [mobile app][not blocking] → [mobile app][blocking][tef-triage]
Just changed the locales in my patch, as the screen is an alert and not a confirm, the new implementation won't be quick, we should open a follow up to address that.
Attached file patch in github —
Attachment #8495900 - Flags: review?(borja.bugzilla)
(In reply to Arnau March [:arnau] from comment #5) > Just changed the locales in my patch, as the screen is an alert and not a > confirm, the new implementation won't be quick, we should open a follow up > to address that. Opened bug 1073498 for that enhancement
Whiteboard: [mobile app][blocking][tef-triage] → [mobile app][blocking][tef-triage][patch available]
Comment on attachment 8495900 [details] [review] patch in github Please rebase and merge it! Thanks!
Attachment #8495900 - Flags: review?(borja.bugzilla) → review+
Merged: 4e1f2b4d7c6a5c418c5adc1f895bb681200a0422
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Tested with Gecko-675810c.Gaia-092d2b7 and Loop v. d159db7 and works fine
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: