move attribute mapping out of content nodes

RESOLVED WONTFIX

Status

()

Core
CSS Parsing and Computation
P3
normal
RESOLVED WONTFIX
16 years ago
4 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
Future
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

16 years ago
We should move the attribute mapping code out of the content nodes for the
following reasons:
 * It would be easier to maintain if it's in one place, in the style system
(near nsHTMLStyleSheet.cpp and nsHTMLMappedAttributes.cpp).
 * The attribute mapping code doesn't logically belong in content -- content
shouldn't know about the style system, except for exposing a few DOM methods.
 * If we don't recombine layout and content, it's the main obstacle to moving
all style system code back into the layout library.
 * It gives the DOM folks one more excuse to keep all the separate content node
implementations with the forwarding, etc.

The tag names could be handled using a perfect hash. 
Seehttp://lxr.mozilla.org/classic/source/lib/libparse/
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → Future
(Assignee)

Comment 1

16 years ago
Er, http://lxr.mozilla.org/classic/source/lib/libparse/
If you're going to rewrite this, could you make the apis non-html specific, so
that SVG can take advantage of this without having to copy code arround?
(Assignee)

Comment 3

16 years ago
There are also similar tools in
http://lxr.mozilla.org/seamonkey/source/layout/tools/
(Assignee)

Comment 4

16 years ago
See also the directory structure proposed in bug 107101.
(Assignee)

Updated

16 years ago
Blocks: 114713
Yeah, the hash would have to be keyed on the namespace as well as the tagname.
(Assignee)

Updated

16 years ago
Depends on: 127269
(Assignee)

Updated

11 years ago
QA Contact: ian → style-system
(Assignee)

Comment 6

6 years ago
I think this was based on a false notion of modularity.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.