Pinboard "save" button not appearing on treeherder production

RESOLVED FIXED

Status

Tree Management
Treeherder
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: camd)

Tracking

Details

Attachments

(1 attachment)

49 bytes, text/x-github-pull-request
mdoglio
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
1) Go to https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central (make sure logged in)
2) Select multiple failing jobs
3) Fill out the pinboard
4) Try to submit the failure classification

Expected:
Save button visible & works.

Actual:
Save button is not visible.

This works on dev, just not production, so this may well be fixed by a grunt build and a re-push to prod, but if not, we need a bug tracking this given it's a blocker.
(Assignee)

Comment 1

3 years ago
Ed--  You're exactly right that it was with the grunt build.  The HTML minification couldn't handle <textarea ..atrs.. /> and needed to be <textarea ..attrs..></textarea> instead.  I saw a flag that this wasn't supported in some browsers and sure enough, that was the culprit.

creating a PR now...
(Assignee)

Updated

3 years ago
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8493173 [details] [review]
pull request
Attachment #8493173 - Flags: review?(mdoglio)
(Reporter)

Updated

3 years ago
Depends on: 1071092

Comment 4

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/67dd66fe90093791a1ae42489abf8623fd0e9be8
Merge pull request #198 from mozilla/bug-1071025-save-button

bug 1071025 - save button not showing for classifying
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Attachment #8493173 - Flags: review?(mdoglio) → review+

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/49c40eed492c02702f8e47a6f3675bb4a469501c
bug 1071025 - save button not showing for classifying

https://github.com/mozilla/treeherder/commit/a3392f3a28d54deefea23c330218b9b21c895f18
bug 1071025
 make the grunt process more resilient to this issue

https://github.com/mozilla/treeherder/commit/913ccecaf565806fcec43dfbad094230a70efa20
Merge pull request #198 from mozilla/bug-1071025-save-button

bug 1071025 - save button not showing for classifying
You need to log in before you can comment on or make changes to this bug.