1071025 - Pinboard "save" button not appearing on treeherder production

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

1) Go to https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central (make sure logged in)
2) Select multiple failing jobs
3) Fill out the pinboard
4) Try to submit the failure classification

Expected:
Save button visible & works.

Actual:
Save button is not visible.

This works on dev, just not production, so this may well be fixed by a grunt build and a re-push to prod, but if not, we need a bug tracking this given it's a blocker.

Comment 1

[Cameron Dawson [:camd]]

Ed--  You're exactly right that it was with the grunt build.  The HTML minification couldn't handle <textarea ..atrs.. /> and needed to be <textarea ..attrs..></textarea> instead.  I saw a flag that this wasn't supported in some browsers and sure enough, that was the culprit.

creating a PR now...

Comment 2

[Cameron Dawson [:camd]]

Attachment: pull request

Comment 3

[Cameron Dawson [:camd]]

fixed in:

https://github.com/mozilla/treeherder-ui/commit/8c0b39ba78f87c41c415508934d201e09754cd89
https://github.com/mozilla/treeherder-ui/commit/590cf6654e85aa0899d226e0ad10076c6395c57f

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/67dd66fe90093791a1ae42489abf8623fd0e9be8
Merge pull request #198 from mozilla/bug-1071025-save-button

bug 1071025 - save button not showing for classifying

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/49c40eed492c02702f8e47a6f3675bb4a469501c
bug 1071025 - save button not showing for classifying

https://github.com/mozilla/treeherder/commit/a3392f3a28d54deefea23c330218b9b21c895f18
bug 1071025
 make the grunt process more resilient to this issue

https://github.com/mozilla/treeherder/commit/913ccecaf565806fcec43dfbad094230a70efa20
Merge pull request #198 from mozilla/bug-1071025-save-button

bug 1071025 - save button not showing for classifying