1071092 - Investigate ways to catch the bug 1071025 minification issue during grunt build or on travis

Status: RESOLVED INCOMPLETE

(Tree Management :: Treeherder, defect, P4)

Description

[Ed Morley [:emorley]]

In bug 1071025, dev was working but production broken, since production uses the minified assets (generated by the grunt build script) whereas dev uses the originals.

We should either:
1) See if additional minification/grunt build warnings can be enabled, so an error/warning would be generated during the grunt build, that would make it clear the minified output would be broken.
2) Run a html5 validator against the markup as part of the travis run, so we can catch any non-standard markup that might break the minification. This combined with running jshint on travis would hopefully mean we would catch any issues that could break grunt build.

Comment 1

[Cameron Dawson [:camd]]

In my PR for bug 1071025 I added a flag to the grunt htmlmin task to ``keepClosingSlash`` which would have prevented this error.  however, that is specific only to that bug, not the html as a whole.  There is a ``lint`` flag, but it doesn't seem to work quite right yet.  I'm working on that now.

Comment 2

[Cameron Dawson [:camd]]

Will come back to this later, but fwiw, here's the top of the output I get when I attempt to use the ``lint: true`` option:

Running "ngtemplates:treeherder" (ngtemplates) task
Warning: TypeError: Object true has no method 'testElement'

Comment 3

[Cameron Dawson [:camd]]

Un-assigning from myself.  I'm not going to get to this soon.