Investigate ways to catch the bug 1071025 minification issue during grunt build or on travis

RESOLVED INCOMPLETE

Status

Tree Management
Treeherder: Docs & Development
P4
normal
RESOLVED INCOMPLETE
3 years ago
a year ago

People

(Reporter: emorley, Unassigned)

Tracking

Details

(Reporter)

Description

3 years ago
In bug 1071025, dev was working but production broken, since production uses the minified assets (generated by the grunt build script) whereas dev uses the originals.

We should either:
1) See if additional minification/grunt build warnings can be enabled, so an error/warning would be generated during the grunt build, that would make it clear the minified output would be broken.
2) Run a html5 validator against the markup as part of the travis run, so we can catch any non-standard markup that might break the minification. This combined with running jshint on travis would hopefully mean we would catch any issues that could break grunt build.
In my PR for bug 1071025 I added a flag to the grunt htmlmin task to ``keepClosingSlash`` which would have prevented this error.  however, that is specific only to that bug, not the html as a whole.  There is a ``lint`` flag, but it doesn't seem to work quite right yet.  I'm working on that now.

Updated

3 years ago
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Will come back to this later, but fwiw, here's the top of the output I get when I attempt to use the ``lint: true`` option:

Running "ngtemplates:treeherder" (ngtemplates) task
Warning: TypeError: Object true has no method 'testElement'
(Reporter)

Updated

3 years ago
Blocks: 1072681
No longer blocks: 1059400
(Reporter)

Updated

3 years ago
Depends on: 1080419
(Reporter)

Updated

3 years ago
Priority: P1 → P3
(Reporter)

Updated

3 years ago
No longer blocks: 1072681
Component: Treeherder → Treeherder: Docs & Development
(Reporter)

Updated

3 years ago
No longer depends on: 1080419
(Reporter)

Updated

3 years ago
Depends on: 1110107
(Reporter)

Updated

3 years ago
Priority: P3 → P4
Un-assigning from myself.  I'm not going to get to this soon.
Assignee: cdawson → nobody
(Reporter)

Updated

2 years ago
Status: ASSIGNED → NEW
(Reporter)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.