Fix command line help for updater

RESOLVED FIXED in Firefox 34

Status

()

Toolkit
Application Update
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
mozilla35
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

For Mac v2 signing an additional command line param was added. Now it should be
fprintf(stderr, "Usage: updater patch-dir install-dir apply-to-dir [wait-pid [callback-working-dir callback-path args...]]\n");

This bug will fix that and the documentation
Created attachment 8493250 [details] [diff] [review]
pach rev1
Attachment #8493250 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8493250 [details] [diff] [review]
pach rev1

Review of attachment 8493250 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/updater/updater.cpp
@@ +2227,5 @@
>    InitProgressUI(&argc, &argv);
>  
>    // To process an update the updater command line must at a minimum have the
> +  // directory path containing the updater.mar file to process as the first
> +  // argument the install directory as the second argument, and the directory to

nit: a comma after "[...] updater.mar file to process as the first argument" might help readability.
Attachment #8493250 - Flags: review?(spohl.mozilla.bugs) → review+
Created attachment 8493260 [details] [diff] [review]
patch - addressed comment
Attachment #8493250 - Attachment is obsolete: true
Attachment #8493260 - Flags: review+
Pushed to oak
https://hg.mozilla.org/projects/oak/rev/ab7770c47443
I've also updated the wiki
https://wiki.mozilla.org/Software_Update:Manually_Installing_a_MAR_file
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/818b73513ce2
Blocks: 1074627
https://hg.mozilla.org/mozilla-central/rev/818b73513ce2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34: --- → fixed
status-firefox35: --- → fixed
You need to log in before you can comment on or make changes to this bug.