1074627 - Modify update verify scripts for new updater arg

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Bug 1071134 describes the changes made to the updater executable to support mac v2 signing. We'll probably need to adjust 
 http://hg.mozilla.org/build/tools/file/83156a061339/release/common/check_updates.sh#l49
prior to 34.0b2.

Comment 1

[[e-mail] (:bhearsum)]

The tricky thing here might be coping with the old and the new style at the same time, since they have a different number of required args.

Comment 2

[Massimo Gervasini [:massimo]]

Attachment: [tools] Bug 1074627 - Modify update verify scripts for new updater arg.patch

Temporary fix for update_verify errors

Comment 3

[Massimo Gervasini [:massimo]]

Temporary fix landed, updated tags, and then backed it out.
We need a more generic solution for this problem.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] Use old calling style for Gecko < 34

Works on my laptop (mac), need to test on other platforms. Removes support of previous calling style, which was used up to Firefox 3.6.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8509199 [details] [diff] [review]
[tools] Use old calling style for Gecko < 34

mgerva, thanks for the first hunk of this. The whole thing has tested fine on win32/mac/linux64 using a truncated beta config (just one locale, 33.0b9 and 34.0b1 -> 34.0b2). Hopefully we can get it landed before 34.0b3 starts. 

I'm removing the previous use of use_old_updater, which was a global from the command line, since it was used for Firefox older than v4.0. We don't need to do update verify for that any more. It becomes a variable we reset after each line is read from the config, depending on the version we're testing this time.

Callek, did I map Gecko 34 to the SeaMonkey version correctly ?

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Windows log

Comment 7

[Massimo Gervasini [:massimo]]

Comment on attachment 8509199 [details] [diff] [review]
[tools] Use old calling style for Gecko < 34

Great, thanks Nick!

Callek, I have r+ and landed this. We are expecting a build3 soon but if there are any issues with SeaMonkey version mappings, I'll be happy to fix them.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Worked for Firefox 34.0b3 build2 and 33.0.1 build2.