1071205 - android::SoftAVCEncoder crashes while recording video in Firefox OS v2.1 Camera app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

move to FireFox OS :General because cmaera app still use the mozCamera API, not MediaRecorder.

Comment 2

[cafbot (PoC: ggrisco)]

Observed on: 

Device: msm8226
Gonk Version: AU_LINUX_GECKO_B2G_KK_2.0.01.04.00.114.085
Moz BuildID: 20140916000206
B2G Version: ---
Gecko Version: 34.0a2
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=713448b8963cd53c561f4b38640f8c63b655ce33
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=395370094caa386ebf8fe8831d030bc5484fa599
Patches: bug 1055299, bug 1044125, bug 1051633, bug 1067205, bug 1070431, bug 1063877, bug 1070195, bug 1064376, bug 1057220

Comment 3

[Diego Wilson [:diego]]

Marking [POVB] as it looks like a vendor issue for now.

Comment 4

[cafbot (PoC: ggrisco)]

Observed on: 

Device: msm8226
Gonk Version: AU_LINUX_GECKO_B2G_KK_2.0.01.04.00.114.127
Moz BuildID: 20141029001202
B2G Version: ---
Gecko Version: 34.0
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=eb0aab0f13c78c7ac378ad860e865c4b6eaf669f
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=e16ae12c5ab365be13fb2c98d3811b93b25ded6d
Patches: bug 1070431, bug 1083449

Comment 5

[Diego Wilson [:diego]]

As comment 4 notes this crash happened again in a recent v2.1 build. I'm reopening and will add crash details shortly.

Comment 6

[Diego Wilson [:diego]]

Attachment: Crash stack

Add crash stack

Comment 7

[Diego Wilson [:diego]]

The crash was due to a null check on the init params during in software encoder initialization [1].

Looks like the init params are only set to null on destruction [2], so most likely the problem is that the software encoder received buffers after it was destroyed.

[1] https://www.codeaurora.org/cgit/quic/la/platform/frameworks/av/tree/media/libstagefright/codecs/avc/enc/SoftAVCEncoder.cpp?id=AU_LINUX_GECKO_B2G_KK_2.0.01.04.00.114.121#n219

[2] https://www.codeaurora.org/cgit/quic/la/platform/frameworks/av/tree/media/libstagefright/codecs/avc/enc/SoftAVCEncoder.cpp?id=AU_LINUX_GECKO_B2G_KK_2.0.01.04.00.114.121#n352

Comment 8

[Diego Wilson [:diego]]

Hi Sotaro,

There may be some stale buffers reaching the software encoder after destruction. Any idea who can help us here?

Comment 9

[Sotaro Ikeda [:sotaro]]

SoftAVCEncoder seems a big problem here. During camera recording hw decoder should be used.

Comment 10

[Sotaro Ikeda [:sotaro]]

diego, can you provide the STR of the crash?

Comment 11

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #10)
> diego, can you provide the STR of the crash?

And can you also provide the logcat log? Thanks.

Comment 12

[Sotaro Ikeda [:sotaro]]

In current gecko, OMX hw encoder resource is not managed/controlled on gonk. Therefore, if hw encoder resource allocation contention happens, the phone could just failed to allocate hw encoder and might fallback to sw encoder.

Comment 13

[Diego Wilson [:diego]]

Attachment: Extra file with log

Here is the extra file with log included.

Unfortunately I don't have STR. This happened during automated stability camera testing.

Comment 14

[Sotaro Ikeda [:sotaro]]

Hmm, attachment 8518297 [details] seems not include necessary information.

Comment 15

[Diego Wilson [:diego]]

Sorry, the full logs are too large to add as an attachment. You can download the zip from here:

https://www.dropbox.com/s/d8xbiymb5jofrsy/bug-1071205-logs.zip?dl=0

Comment 16

[Sotaro Ikeda [:sotaro]]

Thanks for the log. From the log, hw encoder seems to emitting error. The following is related part.

> 11-04 16:13:06.594   300  7543 E mm-camera: stats_port_event: Failure posting to the bus!
> 11-04 16:13:06.594   202  7554 D QCamera2HWI: static void qcamera::QCamera2HardwareInterface::metadata_stream_cb_routine(mm_camera_super_buf_t*, qcamera::QCameraStream*, void*): hdr_scene_data: 1 0 0.000000
> 11-04 16:13:06.594   202  7554 E QCamera2HWI: int32_t qcamera::QCamera2HardwareInterface::processHDRData(cam_asd_hdr_scene_data_t) : hdr_scene_data: processHDRData: 0 0.000000
> 11-04 16:13:06.594  2968  3270 D GonkNativeWindow: GonkNativeWindow::returnBuffer
> 11-04 16:13:06.604   202  7555 D QCamera2HWI: [KPI Perf] static void qcamera::QCamera2HardwareInterface::preview_stream_cb_routine(mm_camera_super_buf_t*, qcamera::QCameraStream*, void*) : END
> 11-04 16:13:06.604   202  7583 E OMX-VENC-720p: HW Error recieved
> 11-04 16:13:06.604   202  7583 E OMX-VENC-720p: ERROR: async_msg_process() - Error statuscode = 1
> 11-04 16:13:06.614   300  7475 E mm-camera: cpp_hardware_process_frame:855] stream_status:0xb88e82f4, iden:0x10008, cur_frame_id:50
> 11-04 16:13:06.614   300  7543 E mm-camera: msg_bus_post_msg: bus_msg type is not valid
> 11-04 16:13:06.614   300  7543 E mm-camera: stats_port_event: Failure posting to the bus!
> 11-04 16:13:06.614   300  7543 E mm-camera: msg_bus_post_msg: bus_msg type is not valid
> 11-04 16:13:06.614   300  7543 E mm-camera: stats_port_event: Failure posting to the bus!
> 11-04 16:13:06.614   300  7543 E mm-camera: msg_bus_post_msg: bus_msg type is not valid
> 11-04 16:13:06.614   300  7543 E mm-camera: stats_port_event: Failure posting to the bus!
> 11-04 16:13:06.614  2968  2974 E OMXCodec: [OMX.qcom.video.encoder.avc] ERROR(0x80001009, 0)

Comment 17

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Change Video encode to HardwareCodecsOnly

Comment 18

[Sotaro Ikeda [:sotaro]]

attachment 8518535 [details] [diff] [review] restricts to use only hw encoder for video encoding. It seems to prevent fallback to software video encoder. But it does not address hw video encoder's error.

Comment 19

[Sotaro Ikeda [:sotaro]]

software video encoder can not be used for the product. Therefore this restriction seems ok. And it could prevent SoftAVCEncoder crashes.

Comment 20

[Sotaro Ikeda [:sotaro]]

diego, how do you think about attachment 8518535 [details] [diff] [review]?

Comment 21

[Diego Wilson [:diego]]

Comment on attachment 8518535 [details] [diff] [review]
patch - Change Video encode to HardwareCodecsOnly

Review of attachment 8518535 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. I don't know what's the general opinion in the media team here, though.

Comment 22

[Sotaro Ikeda [:sotaro]]

ICS already limit video encoder only to Hw video encoder. Therefore the change seems OK.

Comment 23

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8518535 [details] [diff] [review]
patch - Change Video encode to HardwareCodecsOnly

mikeh, can you review the patch?

Comment 24

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=f1909db8a219

Comment 25

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8518535 [details] [diff] [review]
patch - Change Video encode to HardwareCodecsOnly

Review of attachment 8518535 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

One suggestion, but I don't feel particularly strongly about it.

::: dom/camera/GonkRecorder.cpp
@@ +1268,5 @@
>      // CHECK_EQ causes an abort if the given condition fails.
>      CHECK_EQ(client.connect(), (status_t)OK);
>  
>      uint32_t encoder_flags = 0;
> +    encoder_flags |= OMXCodec::kHardwareCodecsOnly;

uint32_t encoder = OMXCodec::kHardwareCodecsOnly; ?

Comment 26

[Sotaro Ikeda [:sotaro]]

(In reply to Mike Habicher [:mikeh] from comment #25)
> 
> ::: dom/camera/GonkRecorder.cpp
> @@ +1268,5 @@
> >      // CHECK_EQ causes an abort if the given condition fails.
> >      CHECK_EQ(client.connect(), (status_t)OK);
> >  
> >      uint32_t encoder_flags = 0;
> > +    encoder_flags |= OMXCodec::kHardwareCodecsOnly;
> 
> uint32_t encoder = OMXCodec::kHardwareCodecsOnly; ?

Yhea, it is simpler.

Comment 27

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/badfce143136

Comment 28

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/badfce143136