1071235 - [video] Accessing the full screen view in the youtube app, restricts user from using any of the video functionalities

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Wasiem Hamadeh [:WasiemH]]

Attachment: logcat_20140922_1336.txt

Description:
After entering full screen mode in a video on the youtube app, user cannot apply any video functions: play, forward, rewind, pause, exit, etc.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140922063004
2) Download Youtube app from market place.
3) Play a video and enter full screen mode.
4) Attempt to pull up video options and exit.

Actual:
Video options prompt fails to appear when touching the screen and cannot exit video.
  
Expected: 
Video options prompt appears when touching the screen and user is able to exit video.

Environmental Variables:
Device: Flame 2.1
BuildID: 20140922063004
Gaia: 689c4ad4d8c3e4aa95805a2e49ae6cf786a1ae91
Gecko: 185fc54d29c1
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  

Repro frequency: 100%
See attached: logcat, video clip: http://youtu.be/lW8gqrDTghw

Comment 1

[Wasiem Hamadeh [:WasiemH]]

Issue DOES occur on Flame 2.1 (512mb), Open-c 2.1, Flame 2.2, Open-c 2.2, Flame 2.2kk

After entering full screen mode in a video on the youtube app, user cannot apply any video functions: play, forward, rewind, pause, exit, etc.

Flame 2.2 (319mb)

Environmental Variables:
Device: Flame 2.2 
Build ID: 20140922040204
Gaia: c7ef0bf06ce1c98cbe68aa52e2ecd862acb23e9c
Gecko: 53f7f5b6d7bf
Version: 35.0a1 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Open C 2.2

Environmental Variables:
Device: Open_C 2.2
Build ID: 20140922040204
Gaia: c7ef0bf06ce1c98cbe68aa52e2ecd862acb23e9c
Gecko: 53f7f5b6d7bf
Version: 35.0a1 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.2 (319mb)

Device: Flame 2.2
BuildID: 20140922043003
Gaia: 3802009e1ab6c3ddfc3eb15522e3140a96b33336
Gecko: 5e704397529b
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Open C 2.1

Environmental Variables:
Device: Open_C 2.1
Build ID: 20140922000332
Gaia: b3f9b97d16a1ab55f80239d63c1a85c3da3d39ad
Gecko: 2c6e3261c47b
Version: 34.0a2 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.1 (512mb)

Environmental Variables:
Device: Flame 2.1 
Build ID: 20140922000332
Gaia: b3f9b97d16a1ab55f80239d63c1a85c3da3d39ad
Gecko: 2c6e3261c47b
Version: 34.0a2 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.1 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.1
Build ID: 20140922063004
Gaia: 689c4ad4d8c3e4aa95805a2e49ae6cf786a1ae91
Gecko: 185fc54d29c1
Version: 34.0a2 
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Issue does NOT occur on: Flame 2.0 (319mb), Flame 2.0 (319mb)JB base, Flame 2.0 (319mb)KK base, Open-c 2.0

Video options prompt appears when touching the screen and user is able to exit video.

Flame 2.0 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.0 
Build ID: 20140922082143
Gaia: 0658006be8a00fdb5931ee15a0aa353a3ab231ba
Gecko: dc61f92b855e
Version: 32.0 (2.0)
Firmware Version: 
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 2.0 (319mb)

Environmental Variables:
Device: Flame 2.0 
Build ID: 20140922000331
Gaia: 0658006be8a00fdb5931ee15a0aa353a3ab231ba
Gecko: c0086da55273
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Open_C 2.0

Environmental Variables:
Device: Open_C 2.0 
Build ID: 20140922000331
Gaia: 0658006be8a00fdb5931ee15a0aa353a3ab231ba
Gecko: c0086da55273
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

The first instance of the Flame 2.2 environmental veriables in comment 1 should actually be the Flame 2.1 (512mb)

Flame 2.1 KitKat Base (512mb)

Environmental Variables:
Device: Flame 2.1
BuildID: 20140924000243
Gaia: 93a99bea0b40d81bd063f7d8b1964dc1ba35ba7b
Gecko: d7e31ecd48af
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 3

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

The user will not be able to get out of fullscreen except by going to the homescreen or force closing the webpage. And this is a regression. Nominating this for 2.1 blocker

Comment 4

[Adam Alldredge [:AdamA][Inactive]]

----------------------------------------------------
Mozilla Central Regression Window
----------------------------------------------------

Last working:
Device: Flame 2.1
BuildID: 20140802202930
Gaia: 5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb
Gecko: e6614d8d85f9
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame 2.1
BuildID: 20140804041427
Gaia: af9a0a24fb9f4c5ced3602bc14053bd49b136344
Gecko: 71497ed2e0db
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb
Gecko: 71497ed2e0db

First Broken Gaia Last working Gecko: Issue DOES reproduce
Gaia: af9a0a24fb9f4c5ced3602bc14053bd49b136344
Gecko: e6614d8d85f9

Pushlog:
https://github.com/mozilla-b2g/gaia/compare/5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb...af9a0a24fb9f4c5ced3602bc14053bd49b136344

----------------------------------------------------
B2G-Inbound Regression Window
----------------------------------------------------

Last working:
Device: Flame 2.1
BuildID: 20140802151227
Gaia: a78866090e213c8321a5d19e01475276727affb6
Gecko: 9c6c2a98b9e7
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame 2.1
BuildID: 20140803122727
Gaia: c987645e91a87615e2faf3c0a76e114c0a5009b3
Gecko: 4a390946b5c9
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: a78866090e213c8321a5d19e01475276727affb6
Gecko: 4a390946b5c9

First Broken Gaia Last working Gecko: Issue DOES reproduce
Gaia: c987645e91a87615e2faf3c0a76e114c0a5009b3
Gecko: 9c6c2a98b9e7

Pushlog:
https://github.com/mozilla-b2g/gaia/compare/a78866090e213c8321a5d19e01475276727affb6...c987645e91a87615e2faf3c0a76e114c0a5009b3

Caused by Bug 1047829

Comment 5

[Joshua Mitchell (Inactive)]

Broken by Bug 1047829 ? Can you take a look Vivien?

Comment 6

[Gregor Wagner [:gwagner]]

Breaking basic functionality.
Vivien, should be back-out bug 1047829?

Comment 7

[Kevin Grandon :kgrandon]

I've reverted bug 1047829 locally and the issue still persists.

I also think this is most likely a gecko regression, so I'm not convinced that the regression range is correct. I'm adding the regressionwindow-wanted keyword again in an attempt to see if we can validate the regression range in comment 4.

Comment 8

[Joshua Mitchell (Inactive)]

removing blocking-bug based on comment 7 -

Comment 9

[:gerard-majax]

I've been experiencing this on my Xperia ZR also. Taking to see what I can do.

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I ended up with the same window as Adam.

I spent a significant amount of time on the last workings for both central and b2g-inbound a well as the last working gaia / first broken gecko for both in order to break them but it didn't happen.  I also didn't look at Adam's results very closely until I was nearly done to prevent it from tainting my own views on the tests.

Central Regression Window:

Last Working 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140802202930
Gaia: 5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb
Gecko: e6614d8d85f9
Version: 34.0a1 (2.1) 
Firmware Version: L1TC00011230
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140804041427
Gaia: af9a0a24fb9f4c5ced3602bc14053bd49b136344
Gecko: 71497ed2e0db
Version: 34.0a1 (2.1) 
Firmware Version: L1TC00011230
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb
Gecko: 71497ed2e0db

First Broken gaia / Last Working gekko - Issue DOES occur
Gaia: af9a0a24fb9f4c5ced3602bc14053bd49b136344
Gecko: e6614d8d85f9

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb...af9a0a24fb9f4c5ced3602bc14053bd49b136344


B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140802151227
Gaia: a78866090e213c8321a5d19e01475276727affb6
Gecko: 9c6c2a98b9e7
Version: 34.0a1 (2.1) 
Firmware Version: L1TC00011230
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


First Broken 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140803122727
Gaia: c987645e91a87615e2faf3c0a76e114c0a5009b3
Gecko: 4a390946b5c9
Version: 34.0a1 (2.1) 
Firmware Version: L1TC00011230
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: a78866090e213c8321a5d19e01475276727affb6
Gecko: 4a390946b5c9

First Broken gaia / Last Working gekko - Issue DOES occur
Gaia: c987645e91a87615e2faf3c0a76e114c0a5009b3
Gecko: 9c6c2a98b9e7

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/a78866090e213c8321a5d19e01475276727affb6...c987645e91a87615e2faf3c0a76e114c0a5009b3

Comment 11

[Joshua Mitchell (Inactive)]

Window is the same - Perhaps this is caused by some Gonk change that happened in between the first broken and last working of this window?

Comment 12

[:gerard-majax]

(In reply to Joshua Mitchell [:Joshua_M] from comment #11)
> Window is the same - Perhaps this is caused by some Gonk change that
> happened in between the first broken and last working of this window?

You are just flashing Gecko/Gaia, right?

Comment 13

[:gerard-majax]

Ok, I do still reproduce this on my master build.

Comment 14

[:gerard-majax]

Ok, I'm rebuilding just prior the given regression window.

Comment 15

[:gerard-majax]

I don't reproduce with:
 gecko 67466f4ff138393b30f0f793d760b24bed467900
 gaia a78866090e213c8321a5d19e01475276727affb6

i.e., each repo just prior the regression window breakage identified.

Comment 16

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #15)
> I don't reproduce with:
>  gecko 67466f4ff138393b30f0f793d760b24bed467900
>  gaia a78866090e213c8321a5d19e01475276727affb6
> 
> i.e., each repo just prior the regression window breakage identified.

Neither with:
 gecko a6009d333c60e47ef79a1d174ec4d93c91d02e2b
 gaia a78866090e213c8321a5d19e01475276727affb6

Comment 17

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #16)
> Neither with:
>  gecko a6009d333c60e47ef79a1d174ec4d93c91d02e2b
>  gaia a78866090e213c8321a5d19e01475276727affb6

Neither with:
 gecko a6009d333c60e47ef79a1d174ec4d93c91d02e2b
 gaia 2e20dfb616a8ec8f01a7000dd6bdb32eb2b10dc1

Please note that https://github.com/mozilla-b2g/gaia/commit/2e20dfb616a8ec8f01a7000dd6bdb32eb2b10dc1 is exactly what has been documented in comment 10.

Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=a6009d333c60e47ef79a1d174ec4d93c91d02e2b

Comment 18

[:gerard-majax]

After several testing, I can confirm this is a regression from bug 1047829.

Comment 19

[Joshua Mitchell (Inactive)]

(In reply to Alexandre LISSY :gerard-majax from comment #12)
> (In reply to Joshua Mitchell [:Joshua_M] from comment #11)
> > Window is the same - Perhaps this is caused by some Gonk change that
> > happened in between the first broken and last working of this window?
> 
> You are just flashing Gecko/Gaia, right?

Typically the QA-Wanted testers are just shallow flashing builds on top of the base image (v180) - we are going to start adding that to the environmental variables (flash method) starting yesterday so it should be more clear going forward.

Comment 20

[Wasiem Hamadeh [:WasiemH]]

Updated Url to video. New URl http://youtu.be/D4nrR8ZbUBU

Comment 22

[:gerard-majax]

Attachment: subset of bug 1047829 that triggers the bug

After testing, I can assert that this comes from bug 1047829, and more precisely, this part of the changes.

Comment 23

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #22)
> Created attachment 8498717 [details]
> subset of bug 1047829 that triggers the bug
> 
> After testing, I can assert that this comes from bug 1047829, and more
> precisely, this part of the changes.

I could even limit the problem to this part of the changes:

> -.appWindow > .screenshot-overlay.visible {
> -  visibility: visible;
> +.appWindow.scrollable .screenshot-overlay {
> +  background-color: inherit;
> +}

Comment 24

[:gerard-majax]

That's because of the "background-color" statement. I'm doing a rebuild with MOZ_DUMP_PAINTING.

Comment 25

[:gerard-majax]

Attachment: Layers tree dump when tapping the video and the bug is reproduced

Comment 26

[:gerard-majax]

Attachment: Layers tree dump when tapping the video and the bug is NOT reproduced

Comment 27

[:gerard-majax]

Attachment: Gaia PR

A first patch that is a workaround: it looks like there's a Gecko APZC side issue, but given it's 2.1+ I prefer to be safe and that we start with a workaround. Meanwhile, let's file a bug for the Gecko-side and investigate this.

Comment 28

[:gerard-majax]

Comment on attachment 8498807 [details] [review]
Gaia PR

Alive, would you mind reviewing this? Thanks!

Comment 29

[Chris Lord [:cwiiis]]

Removing my needinfo, spoke on IRC but I don't really have any useful suggestions for this I'm afraid :/

Comment 30

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8498807 [details] [review]
Gaia PR

r+ first, but have you ever tried to find out why the visibility of screenshot-overlay is overriden(from hidden to visible?) while there is a fullscreen element?

Comment 31

[:gerard-majax]

Thanks alive. As explained on IRC, and sorry if it was not clear in the bug, all the investigation we could do conducted us to some messed up layer tree. Forcing the visibility was the only safe way we found to fix the mess quickly while letting gfx people investigate the gecko bug. Even deleteting screenshot-overlay was not helping, for instance.

Comment 32

[:gerard-majax]

Try is green: https://tbpl.mozilla.org/?rev=8a479cf11dec689881fa52e7d1f23358a46a4c42&tree=Gaia-Try

Comment 33

[:gerard-majax]

I just updated the PR to add the gecko followup bug in the comment.

Comment 34

[:gerard-majax]

Workaround merged: https://github.com/mozilla-b2g/gaia/commit/6244bf7dbf156b12312370f03d8bf470366bc5c0

Comment 35

[:gerard-majax]

Comment on attachment 8498807 [details] [review]
Gaia PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1076783
[User impact] if declined: user cannot access video controls when viewing a fullscreen video at least on youtube
[Testing completed]: taking screenshots works, video controls properly displayed
[Risk to taking this patch] (and alternatives if risky): low, and easy to backout in case of issue
[String changes made]: none

Comment 36

[[:fabrice] Fabrice Desré]

Comment on attachment 8498807 [details] [review]
Gaia PR

Can you file a follow-up to add tests?

Comment 37

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/4c2645415fb801a8e7a70c5c404b2aea730f8ba5

Comment 38

[Brogan Zumwalt [Inactive]]

Issue occurs and is not fixed on Flame 2.2 KK (319mb) (Full Flash) & Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141010000201
Gaia: bc8eb493311c58f1f311a56b8b645b52bfbd2f71
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

After installing Youtube app from Marketplace, full screen videos do not display video controls. Tapping on the screen does not display or interact with video controls.

Comment 39

[:gerard-majax]

Kats, have a look above, looks like my workaround does not work anymore. I checked on current master, and it seems to also not work anymore :(

I fear we will have to make bug 1076783 a 2.1+ and fix it on gecko properly, workarounds seems to be too prone to breakage.

Comment 40

[Kartikaya Gupta (email:[e-mail])]

(In reply to Alexandre LISSY :gerard-majax from comment #39)
> I fear we will have to make bug 1076783 a 2.1+ and fix it on gecko properly,
> workarounds seems to be too prone to breakage.

That sounds reasonable to me. Feel free to request 2.1+ for bug 1076783. I'll help in any way that I can but it seems to be mostly a layout-side issue so I don't know how much I'll be able to do. roc or mattwoodrow would probably be the best people to look at it, maybe tn if neither of them have time.

Comment 41

[Tony Chung [:tchung]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #40)
> (In reply to Alexandre LISSY :gerard-majax from comment #39)
> > I fear we will have to make bug 1076783 a 2.1+ and fix it on gecko properly,
> > workarounds seems to be too prone to breakage.
> 
> That sounds reasonable to me. Feel free to request 2.1+ for bug 1076783.
> I'll help in any way that I can but it seems to be mostly a layout-side
> issue so I don't know how much I'll be able to do. roc or mattwoodrow would
> probably be the best people to look at it, maybe tn if neither of them have
> time.

confirmed on 2.1, this is still broken.  See my screencast on a 10/11 build:  http://youtu.be/nA8-UGMHETY

if bug 1076783 is the right fix to make this work, i'd like to request that block and also get 2.1 approval.  going to nom that now and mark it blocking this bug.

Comment 43

[Gregor Wagner [:gwagner]]

So we have 3 people that wanted to set bug 1076783 as blocking but nobody actually did it and we lost valuable time :(

Comment 44

[Martijn Wargers (dead)]

(In reply to Gregor Wagner [:gwagner] from comment #43)
> So we have 3 people that wanted to set bug 1076783 as blocking but nobody
> actually did it and we lost valuable time :(

See bug 1076783, comment 19. The smoketest actually didn't cover this, so that's why it wasn't encountered earlier.

Comment 45

[:gerard-majax]

Given that the workaround is broken and a solution is being worked on in the true platform bug 1076783, I propose that we just backout the workaround to avoid pilling up code that is useless.

Comment 46

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1 and 2.2.

Result: The video controller is accessible and fully functional on fullscreen mode.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141110001201
Gaia: 0ec1925fc37b7c71d129ae44e42516a0cfb013c4
Gecko: 97487a2d1ee6
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 (319mb, KK, Full Flash)
BuildID: 20141110040206
Gaia: 5f8206bab97cdd7b547cc2c8953cadb2a80a7e11
Gecko: d380166816dd
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0