1071270 - [Cost Control] Emergency Call icon missing

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: 2014-09-22-14-49-44.png

In the cost control app, the icon for Emergency Call is missing. Also, "EmergencyCall" should have a space so it reads "Emergency Call". See attached screenshot. 

Thanks

Comment 1

[Marina Rodríguez [:mai]]

Hi Patryk,
the "Emergency Call" app doesn't have a defined icon. Would you mind helping us with this issue?

Regards.

Comment 2

[Patryk Adamczyk [:patryk] UX]

Peter La on my team should be able to provide this.
Marina, what release is this for? Specifically how urgent is it?

Comment 3

[Marina Rodríguez [:mai]]

It's for v2.1
Regards

Comment 4

[Peter La]

Attachment: Icon_EmergencyCall_20140926.zip

Hi,

Attached is the emergency call app icon @ 5 sizes.

Comment 5

[Peter La]

Attachment: EmergencyCallSettings.jpg

This is a mockup showing what the icon should look like in context of the Settings screen.

Comment 6

[Peter La]

Ping Pavel.

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

png_recompress was used :)

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 8496105 [details] [review]
patch for Gaia/master

I don't think this is the proper way to fix this. Emergency call should not consume data anyway. It has a "role": "system" in its manifest so I'd rather see it's consumption being folded into the System app.

Comment 9

[Peter La]

Pinging Carrie and Rob for their input.

Comment 10

[Peter La]

This is regarding Anthony's comment, which makes a lot of sense to me.

Comment 11

[Rob MacDonald [:robmac]]

NI'ing Katie as she's working on smart data currently.

Comment 12

[katieC]

I agree with Anthony, Emergency Call should not be in the list. The list should ONLY be displaying apps that have used data.

In 2.2, we'll ideally be setting data usage threshold for the list.

NI'ing Jason Duell - see comment 8: If Emergency Call did in fact use data, would/could it be grouped within "system"?

Comment 13

[Jason Duell]

re: comment 8: data usage gets lumped into "system" if the appID of the app is 0.  I don't know enough about the Emergency Call app to know if that's the case (it sounds like it isn't) or if it would be easy to change that.  I assume not.  The most obvious hack here would be for the Usage app to special-case Emergency call's appID and just lump its usage into System.  (or if the amount of usage it does is trivial, just blacklist it and don't report it).

Comment 15

[Peter Dolanjski [:pdol]]

Salvador/Marshall, is there already a bug to hide apps with no usage?  I can't find one.  That would likely solve many of these issues.

Comment 16

[Marshall Culpepper [:marshall_law]]

Looks like we have Bug 1078654

Comment 17

[Salvador de la Puente González [:salva]]

I'm adding a dependency here as this is a UX issues which could be resolved by implementing hiding 0 usage apps which does not seems very complicated to me and it's a great win if we want ship by-app features.

Comment 18

[Peter Dolanjski [:pdol]]

[Blocking Requested - why for this release]: We cannot ship with a missing icon in the UI, so we either need to fix this issue or implement 1078654.

Comment 19

[Peter Dolanjski [:pdol]]

(In reply to Peter Dolanjski [:pdol] from comment #18)
> [Blocking Requested - why for this release]: We cannot ship with a missing
> icon in the UI, so we either need to fix this issue or implement 1078654.

I take that back, I think this needs to be fixed independent of bug 1078654 so we don't have a missing icon if this app does use data (not sure if it is capable of doing so).

Comment 20

[Maria Angeles Oteo (:oteo)]

(In reply to Peter Dolanjski [:pdol] from comment #19)
> 
> I take that back, I think this needs to be fixed independent of bug 1078654
> so we don't have a missing icon if this app does use data (not sure if it is
> capable of doing so).

According to comment 8, it should not consume data anyway and with bug 1078654 we should not show applications with 0 data usage consumption so I don't see how this bug could happen... 

Can someone from QA team verify if that Emergency calls app can have a data usage value higher than 0?

Comment 21

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Maria,
On the latest central build I was unable to get emergency calls to use data.  I'm leaving the qawanted tag in case slyu can give more information.

Comment 22

[Shing Lyu [:shinglyu]]

I consulted RIL engineer Hsin-Yi Tasi, and she said that the emergency will **not** use mobile data. So I guess we can just fix bug 1078654 and mark this as WONTFIX.

Comment 23

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: setting bug 1078654 as 2.1+

Comment 24

[Maria Angeles Oteo (:oteo)]

As bug 1078654 has already been landed and set to 2.1+, it seems that we are not going to have have this issue anymore, 
Pavel, be free to close the bug as Shing suggested in comment 22.

Comment 25

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks all for the info.