Closed Bug 1071337 Opened 9 years ago Closed 9 years ago

Chat history of closed contacts only shows one entry for Today

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird38+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 38.0
Tracking Flags:
Tracking Status
thunderbird38 + fixed

People

(Reporter: mark.yen, Assigned: aleth)

References

Details

(Keywords: regression)

Attachments

(1 file)

tbtodaylogs.diff
2.03 KB, patch
nhnt11
: review+
Details | Diff | Splinter Review 
Daily build 20140922030203, Linux/x86_64

STR:
1. Start a chat with a contact (I used GTalk); say something
2. Close chat with contact
3. Repeat steps 1 and 2 a few times (so the history gets stitched together)
4. With chat closed, look at "Previous Conversations"

Expected results:
Either multiple "Today" entries, or one entry that shows the stitched-together log

Actual results:
Single "Today" entry, when selected it only shows the last session from today

Additional information:
If you start a conversation (so the contact moves from {Online|Offline Contacts into Conversations) and look at Previous Conversations, the logs get stitched together.
Keywords: regression
We should investigate if this still happens after the changes from bug 955014 and its predecessors land.
Depends on: 955014
Assignee: nobody → nhnt11
tracking-thunderbird38: --- → ?
tracking-thunderbird_esr38: --- → ?
This regression (?) needs looking into for TB38.
No longer depends on: 955014
Instantbird doesn't have this bug.
Attached patch tbtodaylogs.diff — — Splinter Review 
Please test after applying your gloda patch, as I keep getting exceptions from gloda in testing, which may confuse things.
Assignee: nhnt11 → aleth
Status: NEW → ASSIGNED
Attachment #8565747 - Flags: review?(nhnt11)
Comment on attachment 8565747 [details] [diff] [review]
tbtodaylogs.diff

Review of attachment 8565747 [details] [diff] [review]:
-----------------------------------------------------------------

For future reference, here's an explanation of the first hunk in the patch:
http://log.bezut.info/instantbird/150219/#m45

I've tested the patch applied over my patch for bug 1103647 and it works well.

Thanks!
Attachment #8565747 - Flags: review?(nhnt11) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
Depends on: 1135297
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.