1071337 - Chat history of closed contacts only shows one entry for Today

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Mook (work)]

Daily build 20140922030203, Linux/x86_64

STR:
1. Start a chat with a contact (I used GTalk); say something
2. Close chat with contact
3. Repeat steps 1 and 2 a few times (so the history gets stitched together)
4. With chat closed, look at "Previous Conversations"

Expected results:
Either multiple "Today" entries, or one entry that shows the stitched-together log

Actual results:
Single "Today" entry, when selected it only shows the last session from today

Additional information:
If you start a conversation (so the contact moves from {Online|Offline Contacts into Conversations) and look at Previous Conversations, the logs get stitched together.

Comment 1

[aleth [:aleth]]

We should investigate if this still happens after the changes from bug 955014 and its predecessors land.

Comment 2

[aleth [:aleth]]

This regression (?) needs looking into for TB38.

Comment 3

[aleth [:aleth]]

Instantbird doesn't have this bug.

Comment 4

[aleth [:aleth]]

Attachment: tbtodaylogs.diff

Please test after applying your gloda patch, as I keep getting exceptions from gloda in testing, which may confuse things.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8565747 [details] [diff] [review]
tbtodaylogs.diff

Review of attachment 8565747 [details] [diff] [review]:
-----------------------------------------------------------------

For future reference, here's an explanation of the first hunk in the patch:
http://log.bezut.info/instantbird/150219/#m45

I've tested the patch applied over my patch for bug 1103647 and it works well.

Thanks!

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/b2740fce3080