1071518 - Slave health reboot/shutdown fails with "Expecting property name: line 4382 column 1 (char 128981)"

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

I've tried to reboot and also shutdown this machine:
https://secure.pub.build.mozilla.org/builddata/reports/slave_health/slave.html?name=talos-mtnlion-r5-029

However the actions failed with "Expecting property name: line 4382 column 1 (char 128981)".

Comment 1

[Pete Moore [:pmoore][:pete]]

I am able to reproduce:

pmoore@Elisandra:~ $ ssh slaveapi1.build.mozilla.org 'cd /builds/slaveapi/prod; source bin/activate; python -c "import requests; all_devices=requests.get('\''http://hg.mozilla.org/build/tools/raw-file/default/buildfarm/mobile/devices.json'\'').json()"'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/builds/slaveapi/prod/lib/python2.7/site-packages/requests/models.py", line 650, in json
    return json.loads(self.content.decode(encoding), **kwargs)
  File "/tools/python27/lib/python2.7/json/__init__.py", line 326, in loads
    return _default_decoder.decode(s)
  File "/tools/python27/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/tools/python27/lib/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting property name: line 4382 column 1 (char 128981)
pmoore@Elisandra:~ $

Comment 2

[Pete Moore [:pmoore][:pete]]

Checking json file is valid...

Comment 3

[Pete Moore [:pmoore][:pete]]

Looks like a syntax bug introduced in https://hg.mozilla.org/build/tools/rev/41f47fdb78d2

Comment 4

[Ed Morley [:emorley]]

Trailing commas strike again :-)

Comment 5

[Pete Moore [:pmoore][:pete]]

Fixed: https://hg.mozilla.org/build/tools/rev/94d1b963f985

This should have immediate effect, will tail logs now... Things should start cleaning up, since the service queries http://hg.mozilla.org/build/tools/raw-file/default/buildfarm/mobile/devices.json directly...

Comment 6

[Ed Morley [:emorley]]

Thank you :-)

Confirmed working.

Comment 7

[Justin Wood (:Callek)]

(In reply to Ed Morley [:edmorley] from comment #4)
> Trailing commas strike again :-)

Ugh I thought we had jenkins checking that for us.... and I don't recall seeing any errors when that landed.

Comment 8

[Pete Moore [:pmoore][:pete]]

(In reply to Justin Wood (:Callek) from comment #7)
> (In reply to Ed Morley [:edmorley] from comment #4)
> > Trailing commas strike again :-)
> 
> Ugh I thought we had jenkins checking that for us.... and I don't recall
> seeing any errors when that landed.

I've created some unit tests in bug 1071746 for jenkins to run.