1071592 - Fix intermittent failure in test_keyboard.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

Attachment: video.webm

Test test_keyboard.py has failed in the latest v2.1 build: http://jenkins1.qa.scl3.mozilla.com/job/flame-319.mozilla-aurora.ui.functional.non-smoke/60/HTML_Report/

I've been able to reproduce the failure locally, by running the automated test. I couldn't reproduce it manually.
Repro rate: 2 out of 10 runs.
The test is failing because number keyboard is displayed when it is trying to type a string in the comment field. 
I would suggest to add a tap in the comment field before typing any letter, to make sure that the correct keyboard is displayed. 

Traceback (most recent call last):
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/marionette_test.py", line 171, in run
testMethod()
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/tests/python/gaia-ui-tests/gaiatest/tests/functional/keyboard/test_keyboard.py", line 29, in test_keyboard_basic
keyboard.send(self._string[:15])
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py", line 238, in send
self._tap(val)
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py", line 177, in _tap
self.wait_for_element_displayed(*self._key_locator(val))
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 44, in wait_for_element_displayed
lambda m: m.find_element(by, locator).is_displayed())
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/wait.py", line 143, in until
cause=last_exc)
TimeoutException: Traceback (most recent call last):
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/wait.py", line 122, in until
rv = condition(self.marionette)
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 44, in <lambda>
lambda m: m.find_element(by, locator).is_displayed())
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/marionette.py", line 1278, in find_element
response = self._send_message('findElement', 'value', **kwargs)
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/decorators.py", line 35, in _
return func(*args, **kwargs)
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/marionette.py", line 638, in _send_message
self._handle_error(response)
File "/var/jenkins/2/workspace/flame-319.mozilla-aurora.ui.functional.non-smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.3-py2.7.egg/marionette/marionette.py", line 672, in _handle_error
raise errors.NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
TimeoutException: Timed out after 20.1 seconds, caused by <class 'marionette.errors.NoSuchElementException'>

Device firmware (date) 	23 Sep 2014 00:33:44
Device firmware (incremental) 	eng.cltbld.20140923.033335
Device firmware (release) 	4.3
Device identifier 	flame
Gaia date 	22 Sep 2014 15:04:45
Gaia revision 	3742913e11f6
Gecko build 	20140923000204
Gecko revision 	df42b05782aa
Gecko version 	34.0a2

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/24343

Comment 2

[Florin Strugariu [:Bebe]]

merged in https://github.com/mozilla-b2g/gaia/commit/0be3c3f8f951aff397fdb550666b57911028479b

Do we need this in v2.1?

Comment 3

[Viorela Ioia [:viorela]]

Yes, I'll open a PR for uplift

Comment 4

[Viorela Ioia [:viorela]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24432

PR for v2.1

Comment 5

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/86905e14c3ff06a0e6952ba635b6066ad2eea6b4

Comment 6

[Viorela Ioia [:viorela]]

This test has failed again in latest v2.1 build: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-b2g34_v2_1.ui.functional.non-smoke/47/HTML_Report/

The fix in this bug was removed in https://github.com/mozilla-b2g/gaia/commit/bcda6c5f526611a2452e742dd84321001dbe13f2.
It looks like in this case we can't get rid of the scrollIntoView, as it's causing intermittent failure, that I haven't seen lately.

I will open a PR to add back the fix.

Comment 7

[Viorela Ioia [:viorela]]

The issue was fixed in Bug 1095471, by uplift on v2.1