1071939 - Initialize GAIA_MAKE_FLAGS with new var BOARD_GAIA_MAKE_FLAGS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Use case: on Raspberry Pi, we never want to enable the lock screen (NO_LOCK_SCREEN=1) no matter what build flavor.  I'm not sure yet whether we want FTU, but I definitely want it off for now.  The upcoming patch allows board configs to set default gaia build options to allow this.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: patch

mwu, not sure if you're the right reviewer for this.  If there's an already-supported way to do the equivalent of this, please let me know.

Comment 2

[Michael Wu [:mwu]]

Hmm I suspect the "real" way to deal with this is to setup a different GAIA_DEVICE_TYPE, which will let you set different sets of defaults for the device. As a bonus, other RPI like devices can use the same set of settings.

That being said, I have no idea if that's a maintainable approach. Take a look in gaia/build/config/ and the tablet/phone/tv directories in there if you're interested.

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 8494054 [details]
patch

Passing to someone who might have a stronger opinion just in case, but it seems reasonable to me.

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8494054 [details]
patch

I think we can live with this, but you will most likely want to set a new device type in future to set any custom pref/settings/apps.
See the "tv" device type for example:
  https://github.com/mozilla-b2g/gaia/tree/master/build/config/tv

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Thanks for the review!

Sorry to have to ask, but how does one go about landing a gaia patch these days?  Do I still open a PR?

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Also, I agree that a separate device definition that subumes the RPi could make sense in the future, but at the moment I don't know what that definition would look like.  It would be nice to have another port of FFOS to e.g. a Beaglebone to see which bits are common.

Comment 7

[Alexandre Poirot [:ochameau]]

(In reply to Chris Jones [:cjones] mostly inactive; ni?/f?/r? if you need me from comment #5)
> Sorry to have to ask, but how does one go about landing a gaia patch these
> days?  Do I still open a PR?

We are still using PR.

(In reply to Chris Jones [:cjones] mostly inactive; ni?/f?/r? if you need me from comment #6)
> Also, I agree that a separate device definition that subumes the RPi could
> make sense in the future, but at the moment I don't know what that
> definition would look like.

It would just be whatever you need. So it would just be a settings.json file with:
  {"lockscreen.enabled": false, "lockscreen.locked":  false}
And apps-engineering.list/apps-production.list files, just to mention which apps you want to ship. (you can just copy the ones from build/config/phone)
Then, given you needs you can also tweak prefs and more settings as your project progress.

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Alexandre Poirot [:ochameau] from comment #7)
> (In reply to Chris Jones [:cjones] mostly inactive; ni?/f?/r? if you need me
> from comment #5)
> > Sorry to have to ask, but how does one go about landing a gaia patch these
> > days?  Do I still open a PR?
> 
> We are still using PR.

Great, thanks.

> (In reply to Chris Jones [:cjones] mostly inactive; ni?/f?/r? if you need me
> from comment #6)
> > Also, I agree that a separate device definition that subumes the RPi could
> > make sense in the future, but at the moment I don't know what that
> > definition would look like.
> 
> It would just be whatever you need. So it would just be a settings.json file
> with:
>   {"lockscreen.enabled": false, "lockscreen.locked":  false}
> And apps-engineering.list/apps-production.list files, just to mention which
> apps you want to ship. (you can just copy the ones from build/config/phone)
> Then, given you needs you can also tweak prefs and more settings as your
> project progress.

Right, that's the part I'm not sure about :).  I don't even know how we would classify devices like the Raspberry Pi --- it has a lot more potential uses than phone/tablet/tv, everywhere from being a desktop replacement (with keyboard/mouse/monitor) to driving robotics headless (embedded).  If you guys don't mind, I'd like to punt those questions until we have a better idea of the use cases people are applying FFOS to on RPi (and other similar) devices.

We may eventually want a set of classes per use case, like "kiosk", "desktop", "embedded", etc., instead of just one for all RPi (and similar) devices.

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Merged as https://github.com/mozilla-b2g/gaia/commit/ea2f1f329b3071eb41cd4b2f7ba082a511ccbb6c .  Will file a followup about defining device class(es) for Raspberry Pi-like environments.