1072013 - [Video] Opening the video app or tapping the camera icon will cause a white screen transition

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[pete siphantong [:Petes]]

Attachment: cw.txt

Description:
When the user open the video app or tapping the camera icon will cause a white screen transition 

Setup Steps:
1) Flame device is set to 319mb x-heavy

Repro Steps:
1) Update a Flame device to BuildID: 20140923003005
2) Open multiple apps
3) Open the video app
4) Tap the camera icon on landscape or portrait


Actual:
white screen transition 

Expected:
no white screen transition 


Flame 2.1 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.1
BuildID: 20140923003005
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Repro frequency: 100%
See attached: video, logcat, https://www.youtube.com/watch?v=KidBQuxoa8g

Comment 1

[pete siphantong [:Petes]]

This issue also reproduce on the Flame 2.2 KitKat Base (319mb) and the Open C 2.2. There is white screen transition

Flame 2.2 KitKat Base (319mb)

Environmental Variables:
Device:  Flame 2.2 Master
BuildID: 20140923073003
Gaia: 37b8a812c642ca616bf9457cb9b71e45261cdfa8
Gecko: 9e193395b912
Version: 35.0a1 (2.2)
Firmware: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Open C 2.2 

Environmental Variables:
Device: Open_C Master
Build ID: 20140923040203
Gaia: 3c898380b47f298cd3b7a0dacb3a6529e94322d4
Gecko: 790f41c631cc
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

___________________________________________________________________________________________________________________________

This issue does not reproduce on the Flame 2.1 KitKat Base (512mb) and the Flame 2.0 KitKat Base (319mb). No white screen transition 

Flame 2.1 KitKat Base (512mb)

Environmental Variables:
Device: Flame 2.1
BuildID: 20140923003005
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140923063014
Gaia: 6449cc35a8f0704d95acac374ba857bde4b86d6c
Gecko: b930730dba81
Version: 32.0 (2.0)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

nominating this as a blocker, Slow app transition and white screen causes poor UX. Also this is a regression

Comment 3

[Hema Koka [:hema]]

Blocking Reason: Regression and bad user experience (white screen)

Comment 4

[Hema Koka [:hema]]

Punam, please investigate 

Thanks
Hema

Comment 5

[Punam Dahiya [:pdahiya]]

Attachment: PR with fix for bug 1072013

Attaching PR which updates body background-color to #0E1214. Setting background-color explicitly fixes the white screen seen while opening Video app.

Device used: Flame-KK 319 mb 
BuildId:20140929040202
OS ver: 2.2

Hub, I am asking you to review the attached patch as you are familiar with bug 1054105 where we removed background-color as part of simplifying layers. Please review. Thanks

Comment 6

[Punam Dahiya [:pdahiya]]

I have tested the attached patch for white screen seen on opening video app. I wasn't able to replicate white screen seen on tapping camera icon on my Flame, setting NI flag for Petes to help test and confirm if attached patch fixes the white screen seen on tapping camera icon inside video app. Thanks

Comment 7

[Hubert Figuiere [:hub]]

This is a dupe of bug 1069272. Will mark the other as dupe. 

I was about to submit this fix.

Comment 9

[Hubert Figuiere [:hub]]

Comment on attachment 8497045 [details] [review]
PR with fix for bug 1072013

I'm not peer to review this. But I did f+. This is the fix I was about to submit for bug 1069272 which I have new duped with this bug.

John Hu should be able to review.

Thank you kindly.

Comment 10

[pete siphantong [:Petes]]

(In reply to Punam Dahiya from comment #6)
> I have tested the attached patch for white screen seen on opening video app.
> I wasn't able to replicate white screen seen on tapping camera icon on my
> Flame, setting NI flag for Petes to help test and confirm if attached patch
> fixes the white screen seen on tapping camera icon inside video app. Thanks

Hi Punam, was this patch intended for 2.1 or 2.2 on the kit kat base?

Comment 11

[Punam Dahiya [:pdahiya]]

(In reply to pete siphantong [:Petes] from comment #10)
> (In reply to Punam Dahiya from comment #6)
> > I have tested the attached patch for white screen seen on opening video app.
> > I wasn't able to replicate white screen seen on tapping camera icon on my
> > Flame, setting NI flag for Petes to help test and confirm if attached patch
> > fixes the white screen seen on tapping camera icon inside video app. Thanks
> 
> Hi Punam, was this patch intended for 2.1 or 2.2 on the kit kat base?

I have tested it on 2.2 kit kat base and can be easily uplifted to 2.1. Thanks

Comment 12

[pete siphantong [:Petes]]

This issue does not reproduce on the attached patch with the Flame 2.2 KitKat Base (319mb). No white screen transition

Flame 2.2 KitKat Base (319mb) full flash/with patch

Environmental Variables:
Device: Flame Master
Build ID: 20140929040202
Gaia: 7b3eab5d1b41fcc4c0fec84edef473853c567df1
Gecko: 9d66436af432
Version: 35.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 13

[Hubert Figuiere [:hub]]

A quick note: to reproduce you must disable the lock screen (as the video shows) and wait 2-3 seconds before suspend a resume

Comment 14

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8497045 [details] [review]
PR with fix for bug 1072013

This looks good.

Hubert

Should we reopen the bug 1054105?

This PR looks like a revert of patch of bug 1054105. But the difference is this PR puts background color in body instead of in html, body. I don't know if there is any difference in Graphics but the outcome is identical to Gaia.

Comment 15

[Hubert Figuiere [:hub]]

No I don't think we need to reopen bug 1054105. This was an alternative to the style change done there.

Comment 16

[Hubert Figuiere [:hub]]

Comment on attachment 8497045 [details] [review]
PR with fix for bug 1072013

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1054105 caused the regression
[User impact] if declined: we get that white background in transition
[Testing completed]: tested before and after.
[Risk to taking this patch] (and alternatives if risky): not many. Alternative is just reverting bug 1054105 altogether.
[String changes made]: none.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/3d6480e046b1cc6e2e44609ab59b5b1f0ff90340

Comment 18

[Joshua Mitchell (Inactive)]

cleaning keywords - bug is resolved - window is not needed

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/da52f35d48cba316fa1d8eda7f877880c7b2c417

Comment 20

[pete siphantong [:Petes]]

This bug is verified fixed on the Flame 2.1 (319mb) and the Flame 2.2 (319mb)


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Result: no white screen transition when tapping the camera icon on landscape

Comment 21

[pete siphantong [:Petes]]

The Flame 2.1 (319mb) and the Flame 2.2 (319mb) were on x-heavy