1072164 - [PDF Viewer] Image has wrong color (black instead of green)

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P2)

Description

[andi]

Attachment: firefox screenshot

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140917194002

Steps to reproduce:

I try to open a FPDF generated PDF with the pdf.js preview.

Firefox 31 is ok (Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0) ("PDF a4cd1396632c947c41f3f4894c99412 [1.4 FPDF 1.53 / -] (PDF.js: 1.0.68)")

Firefox 32 is not ok. (Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0) ("PDF a4cd1396632c947c41f3f4894c99412 [1.4 FPDF 1.53 / -] (PDF.js: 1.0.277)")


Actual results:

The image is inverted


Expected results:

The image should be transparent and green.

Comment 1

[andi]

Attachment: druckdatei.pdf

Comment 2

[Loic]

It's partially fixed in FF33+, the image is visible but the color is wrong (black instead of green).

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cf89b5d018f8&tochange=7586c29906b5
Regressed by Bug 1007627.

Partial working range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bb35d1b73634&tochange=37f08ddaea48
Partially fixed by Bug 1025878.

As the color is only wrong, I update the title according to the remaining issue.

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

I'm tracking this regression across the board but think it is unlikely that this will be fixed in Firefox 33.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Yury, any chance you could help here? thanks

Comment 5

[Jonas Jenwald [:Snuffleupagus]]

This is a regression from the upstream PR https://github.com/mozilla/pdf.js/pull/4528.

In reference to bug 1072164 comment 2: It was partially addressed by PR https://github.com/mozilla/pdf.js/pull/4892.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Too late for 33 but we have still time for 34 (still in aurora).

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Added to the 33 release notes (known issues)

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Bill - iirc you used to own pdf.js. Can you help out with this lingering bug?

Comment 9

[Brendan Dahl [:bdahl]]

Yury's going to take a look when he gets a chance.

Comment 10

[Yury Delendik (:yury)]

Will work on uplifting https://github.com/mozilla/pdf.js/pull/5414 to current beta

Comment 11

[Yury Delendik (:yury)]

Attachment: Uplift patch for FF34/beta

https://tbpl.mozilla.org/?tree=Try&rev=384c915b31a6

Comment 12

[Yury Delendik (:yury)]

Comment on attachment 8510322 [details] [diff] [review]
Uplift patch for FF34/beta

Approval Request Comment
[Feature/regressing bug #]: bug 1007627
[User impact if declined]: some jpeg images in pdfs might look wrong
[Describe test coverage new/current, TBPL]: in m-c and aurora
[Risks and why]: low, affects only jpeg images in pdfs
[String/UUID change made/needed]: none

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8510322 [details] [diff] [review]
Uplift patch for FF34/beta

Beta+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d1de09f2d1b0

Comment 15

[Gabriela [:gaby2300]]

I can confirm it's fixed using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 and Windows 7 62 bit.

Comment 16

[u489386]

Reproduce with Nightly (Build ID: 20140917030202)
Verified as fixed with latest Firefox 35 beta 1 (Build ID: 20141201162954):
Mozilla/5.0 (Windows NT 6.1; rv:35.0) Gecko/20100101 Firefox/35.0

Comment 17

[Shils]

Hi,

I'm using v.40 and the images are appearing as black as well.

The white boxes starting from page 2 are displayed in black.
Test URL: https://www.pinkribbon.com.au/siteassets/gni/host-booklet.pdf

Comment 18

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Shils from comment #17)
> Hi,
> 
> I'm using v.40 and the images are appearing as black as well.
> 
> The white boxes starting from page 2 are displayed in black.
> Test URL: https://www.pinkribbon.com.au/siteassets/gni/host-booklet.pdf

Shils, you are right, however since the original issue now works this may be a different problem. Can you please file a new bug and post the bug number here? I can then confirm it so people can have a look at it.

Comment 19

[Loic]

(In reply to Florin Mezei, QA (:FlorinMezei) from comment #18)
> (In reply to Shils from comment #17)
> > Hi,
> > 
> > I'm using v.40 and the images are appearing as black as well.
> > 
> > The white boxes starting from page 2 are displayed in black.
> > Test URL: https://www.pinkribbon.com.au/siteassets/gni/host-booklet.pdf
> 
> Shils, you are right, however since the original issue now works this may be
> a different problem. Can you please file a new bug and post the bug number
> here? I can then confirm it so people can have a look at it.

See bug 1194540.