1072167 - [e10s] browser_tabs.js test fails under e10s

Status: RESOLVED WONTFIX

(DevTools Graveyard :: WebIDE, defect, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

4056 INFO Console message: [JavaScript Error: "not well-formed" {file: "file:///o:/src/mozilla-git/gecko-dev/obj-release/_tests/testing/mochitest/chrome/browser/devtools/webide/test/addons/simulators.json" line: 1 column: 1 source: "{"}]
4057 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webide/test/browser_tabs.js | Locally connected 
4058 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webide/test/browser_tabs.js | Location is correct 
4059 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webide/test/browser_tabs.js | Name is correct - Got example.com: Loading…, expected example.com: Test Tab
Stack trace:
    chrome://mochikit/content/browser-test.js:test_is:793
    chrome://mochitests/content/browser/browser/devtools/webide/test/browser_tabs.js:test/<:33
    test@chrome://mochitests/content/browser/browser/devtools/webide/test/browser_tabs.js:11:3
    Tester_execTest@chrome://mochikit/content/browser-test.js:659:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:556:7

It doesn't seem timing related - if I force the test to "stall" at the failure point, the title in the IDE remains "loading" rather than as expected.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 975084 will keep the remote tab form updated, which should resolve this problem.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: browser_tabs test now works in e10s

It was indeed fixed by bug 975084.

Try with e10s: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=25b44a862d29

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to J. Ryan Stinnett [:jryans] from comment #2)
> Created attachment 8505551 [details] [diff] [review]
> browser_tabs test now works in e10s
> 
> It was indeed fixed by bug 975084.
> 
> Try with e10s:
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=25b44a862d29

Try is very upset with the patch, so something is still unfixed here.  I haven't had time to get back to this yet.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

WebIDE is slated for removal, so it's unlikely we'll make a change at the moment.

Comment 5

[Julian Descottes [:jdescottes]]

WebIDE triage. Filter on TRIAGE-JD201705

Comment 6

[Julien Wajsberg [:julienw]]

Attachment: Bug 1072167 - reenable the browser_tabs test

Comment 7

[Julien Wajsberg [:julienw]]

Turns out I looked at it because a red test annoyed me while working on bug 1459720.

Comment 8

[Julien Wajsberg [:julienw]]

The test is too flaky for the time I want to spend there.

Comment 9

[Julian Descottes [:jdescottes]]

WebIDE was completely removed in Bug 1539462 (Firefox 71). Closing all the bugs remaining in the component.