1072278 - Annotate crash reports with e10s information

Status: RESOLVED INVALID

(Core :: General, defect)

Description

[Jim Mathies [:jimm]]

Bug 929012 added annotations tied to browser.tabs.remote, but afaict, that pref isn't set or needed when we enable autostart e10s. In my profile browser.tabs.remote is false and e10s still works. The new Options checkbox doesn't set it either. 

Looking at some e10s related crash reports in bug 1065042, I don't see 'DOMIPCEnabled'.

Comment 1

[Robert Kaiser]

I see that annotation on all crashes that have e10s enabled. Can you point me to a specific one where you are sure e10s is enabled but the annotation is missing?

Comment 2

[Jim Mathies [:jimm]]

(In reply to Robert Kaiser (:[e-mail]) from comment #1)
> I see that annotation on all crashes that have e10s enabled. Can you point
> me to a specific one where you are sure e10s is enabled but the annotation
> is missing?

https://crash-stats.mozilla.com/report/index/cc960924-4e5e-4fcb-81fa-9b8f72140807

Maybe it only shows up in the parent process?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

The annotation is set in a different place nowadays:
http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp#2295
We had to change it to deal with "Open new e10s window".

It was intended to be set only in the parent process. We can already detect child process crashes because they're marked as "Process type" = content.

For ease of querying, it might make sense to set the annotation in the child, too. That would be very easy.

Comment 4

[Robert Kaiser]

I've actually seen the annotation in child processes, even though as you say it's somewhat redundant.

Comment 5

[Jim Mathies [:jimm]]

Ok, if we're sure this is getting sent and that patch I was looking at is out dates, I guess we can close this. Thanks for the clarification.