1072310 - Build more DOM code in unified mode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Build more DOM code in unified mode

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8494516 [details] [diff] [review]
Build more DOM code in unified mode

Review of attachment 8494516 [details] [diff] [review]:
-----------------------------------------------------------------

why you use 'workers' namespace in such way?

::: dom/workers/XMLHttpRequest.cpp
@@ +1211,5 @@
>          if (doClone) {
>            // Anything subject to GC must be cloned.
>            JSStructuredCloneCallbacks* callbacks =
>              aWorkerPrivate->IsChromeWorker() ?
> +            workers::ChromeWorkerStructuredCloneCallbacks(true) :

is it really needed?

Comment 3

[(no longer active)]

(In reply to Andrea Marchesini (:baku) from comment #2)
> Comment on attachment 8494516 [details] [diff] [review]
> Build more DOM code in unified mode
> 
> Review of attachment 8494516 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> why you use 'workers' namespace in such way?
> 
> ::: dom/workers/XMLHttpRequest.cpp
> @@ +1211,5 @@
> >          if (doClone) {
> >            // Anything subject to GC must be cloned.
> >            JSStructuredCloneCallbacks* callbacks =
> >              aWorkerPrivate->IsChromeWorker() ?
> > +            workers::ChromeWorkerStructuredCloneCallbacks(true) :
> 
> is it really needed?

In order to make sure the compiler picks the function ChromeWorkerStructuredCloneCallbacks here, not the constructor of the ChromeWorkerStructuredCloneCallbacks class.  (The function is in namespace mozilla::dom::workers.  Same thing about other similar occurrences.)

Comment 4

[(no longer active)]

Attachment: Build more DOM code in unified mode; r=baku

Comment 5

[(no longer active)]

Comment on attachment 8494984 [details] [diff] [review]
Build more DOM code in unified mode; r=baku

https://tbpl.mozilla.org/?tree=Try&rev=ac80b860b890

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f5d51d092a6