Closed Bug 1072414 Opened 6 years ago Closed 6 years ago

Use outsideOverlay scrollbar style in pre-search UI

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 35

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(3 files)

Attached image scroll.png
So that the scrollbar doesn't overlap with the list of search history entries (see screenshot).
Attachment #8494646 - Flags: review?(margaret.leibovic)
Comment on attachment 8494646 [details] [diff] [review]
Use outsideOverlay scrollbar style in pre-search UI (r=margaret)

Review of attachment 8494646 [details] [diff] [review]:
-----------------------------------------------------------------

Nice touch!
Attachment #8494646 - Flags: review?(margaret.leibovic) → review+
Blocks: search
https://hg.mozilla.org/mozilla-central/rev/15fb93c010c8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Attached image scroll bar.png
The scroll bar overlaps the list of search history entries on Samsung Galaxy S4 (Android 4.4.2).
Tested on build 38.0a1 (2015-01-19).

Should I reopen the bug?
Flags: needinfo?(lucasr.at.mozilla)
redirect to :Margaret
Flags: needinfo?(lucasr.at.mozilla) → needinfo?(margaret.leibovic)
(In reply to Flaviu Cos, QA [:flaviu] from comment #5)
> Created attachment 8551686 [details]
> scroll bar.png
> 
> The scroll bar overlaps the list of search history entries on Samsung Galaxy
> S4 (Android 4.4.2).
> Tested on build 38.0a1 (2015-01-19).
> 
> Should I reopen the bug?

Strange that it only happens on that device. Are there any other devices where you see this? I can't reproduce on a Moto X (4.4.4).

Can you file a new bug? I don't want to reopen this one because it will be confusing to track where changes landed.
Flags: needinfo?(margaret.leibovic)
Depends on: 1125727
(In reply to :Margaret Leibovic from comment #7)
> Strange that it only happens on that device. Are there any other devices
> where you see this? I can't reproduce on a Moto X (4.4.4).
> 
> Can you file a new bug? I don't want to reopen this one because it will be
> confusing to track where changes landed.

My bad. The scroll bar overlaps the search suggestions entries. Logged bug 1125727 for that issue.
Verified as fixed using Samsung Galaxy S4 (Android 4.4.2) and Motorola Razr (Android 4.1.2).
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.