1072414 - Use outsideOverlay scrollbar style in pre-search UI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Lucas Rocha (:lucasr)]

Attachment: scroll.png

So that the scrollbar doesn't overlap with the list of search history entries (see screenshot).

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Use outsideOverlay scrollbar style in pre-search UI (r=margaret)

Comment 2

[:Margaret Leibovic]

Comment on attachment 8494646 [details] [diff] [review]
Use outsideOverlay scrollbar style in pre-search UI (r=margaret)

Review of attachment 8494646 [details] [diff] [review]:
-----------------------------------------------------------------

Nice touch!

Comment 3

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/15fb93c010c8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15fb93c010c8

Comment 5

[Flaviu Cos]

Attachment: scroll bar.png

The scroll bar overlaps the list of search history entries on Samsung Galaxy S4 (Android 4.4.2).
Tested on build 38.0a1 (2015-01-19).

Should I reopen the bug?

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

redirect to :Margaret

Comment 7

[:Margaret Leibovic]

(In reply to Flaviu Cos, QA [:flaviu] from comment #5)
> Created attachment 8551686 [details]
> scroll bar.png
> 
> The scroll bar overlaps the list of search history entries on Samsung Galaxy
> S4 (Android 4.4.2).
> Tested on build 38.0a1 (2015-01-19).
> 
> Should I reopen the bug?

Strange that it only happens on that device. Are there any other devices where you see this? I can't reproduce on a Moto X (4.4.4).

Can you file a new bug? I don't want to reopen this one because it will be confusing to track where changes landed.

Comment 8

[Flaviu Cos]

(In reply to :Margaret Leibovic from comment #7)
> Strange that it only happens on that device. Are there any other devices
> where you see this? I can't reproduce on a Moto X (4.4.4).
> 
> Can you file a new bug? I don't want to reopen this one because it will be
> confusing to track where changes landed.

My bad. The scroll bar overlaps the search suggestions entries. Logged bug 1125727 for that issue.

Comment 9

[Flaviu Cos]

Verified as fixed using Samsung Galaxy S4 (Android 4.4.2) and Motorola Razr (Android 4.1.2).