Closed Bug 1072701 Opened 6 years ago Closed 6 years ago

Build some Firefox OS specific DOM code in unified mode

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → ehsan.akhgari
Blocks: unified
Attachment #8494893 - Flags: review?(amarchesini)
Attachment #8494893 - Attachment is obsolete: true
Attachment #8494893 - Flags: review?(amarchesini)
Comment on attachment 8494983 [details] [diff] [review]
Build some Firefox OS specific DOM code in unified mode; r=baku

https://tbpl.mozilla.org/?tree=Try&rev=0660aac161d3
Attachment #8494983 - Flags: review?(amarchesini)
Comment on attachment 8494983 [details] [diff] [review]
Build some Firefox OS specific DOM code in unified mode; r=baku

Review of attachment 8494983 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/gonk/SmsService.cpp
@@ +14,5 @@
>  
>  uint32_t
>  getDefaultServiceId()
>  {
> +  const char* kPrefRilNumRadioInterfaces = "ril.numRadioInterfaces";

static ?

@@ +41,5 @@
>    mRil = do_GetService("@mozilla.org/ril;1");
>    NS_WARN_IF_FALSE(mRil, "This shouldn't fail!");
>  
>    // Initialize observer.
> +  const char* kObservedPrefs[] = {

static ?

::: dom/mobilemessage/ipc/SmsIPCService.cpp
@@ +79,5 @@
>  
>  uint32_t
>  getDefaultServiceId(const char* aPrefKey)
>  {
> +  const char* kPrefRilNumRadioInterfaces = "ril.numRadioInterfaces";

static

@@ +113,5 @@
>  }
>  
>  SmsIPCService::SmsIPCService()
>  {
> +  const char* kObservedPrefs[] = {

static
Attachment #8494983 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/5293979e38c6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.