1072728 - [soft-home-button] STK query page truncated by soft home button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: STKQuery.png

### STR
1. This is a dictionary app in stk provided by CHT 
2. Try to send out a query

### Actual
STKQuery.png
Soft home bar is covering the buttons of the page

### Version
Gaia-Rev        a7e53d661a1329d6813bc6104555b57dbb5e4d85
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/84d2b47c102d
Build-ID        20140924160202
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140924.193208
FW-Date         Wed Sep 24 19:32:19 EDT 2014
Bootloader      L1TC10011800

Comment 1

[Eric Chang [:ericcc] [:echang]]

Hi Eli, just a heads up, there are some other STK that I am not able to check due to bug 1072730.
https://bug1072730.bugzilla.mozilla.org/attachment.cgi?id=8494959

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, can you take a look here?

Comment 3

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Bad UX with sof home button

Comment 4

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24655

Hey Eric, I cannot access the exact same menu you were having problems with. Could you please verify it gets fixed with this patch? I think that might fix bug 1072730 as well.

Comment 5

[Gregor Wagner [:gwagner]]

see comment 3

Comment 6

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-09-30 12.08.43.jpg

Hi Alberto, I applied the patch, 1072730 is fixed, but 1072728 is still having the issue, please check the attachment, thanks.

(In reply to Alberto Pastor [:albertopq] from comment #4)
> Created attachment 8496793 [details] [review]
> Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24513
> 
> Hey Eric, I cannot access the exact same menu you were having problems with.
> Could you please verify it gets fixed with this patch? I think that might
> fix bug 1072730 as well.

Comment 7

[Alberto Pastor [:albertopq]]

Eric, could you please review again? Just was able to repro it and with the latest patch should be fixed. Still see a weird behaviour of the keyboard when appearing, but it happens as well in any other form input (Contacts, for example) on master, so is not related to this patch.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Alberto Pastor [:albertopq] from comment #7)
> Still see a weird behaviour of the keyboard
> when appearing, but it happens as well in any other form input (Contacts,
> for example) on master, so is not related to this patch.

Alberto, can you file a bug for this issue?

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8496793 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24655

Arthur, can you help us get this reviewed?

Comment 10

[Alberto Pastor [:albertopq]]

(In reply to Michael Henretty [:mhenretty] from comment #8)
> (In reply to Alberto Pastor [:albertopq] from comment #7)
> > Still see a weird behaviour of the keyboard
> > when appearing, but it happens as well in any other form input (Contacts,
> > for example) on master, so is not related to this patch.
> 
> Alberto, can you file a bug for this issue?

I think the autocomplete dictionary confused me :$. Not an actual issue.

Comment 11

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-10-01-19-01-49.png

Hi Alberto, I was not able to acess the STK menu after the 2nd patch, the items are not there. If the SHB is on, the 'Operator Services' in the bottom of the Settings disappears.
(In reply to Alberto Pastor [:albertopq] from comment #7)
> Eric, could you please review again? Just was able to repro it and with the
> latest patch should be fixed. Still see a weird behaviour of the keyboard
> when appearing, but it happens as well in any other form input (Contacts,
> for example) on master, so is not related to this patch.

Comment 12

[Alberto Pastor [:albertopq]]

Mhm, not sure that the fact that you don't see the Operator Services is related to the patch. May be it is, but I can't think how the patch can interfere on the Settings app. Can we talk about it offline? @albertopq on IRC. Thanks!

Comment 13

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8496793 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24655

Thank you Alberto ;)

Comment 14

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Eric Chang [:ericcc] [:echang] from comment #11)
> Created attachment 8498089 [details]
> 2014-10-01-19-01-49.png
> 
> Hi Alberto, I was not able to acess the STK menu after the 2nd patch, the
> items are not there. If the SHB is on, the 'Operator Services' in the bottom
> of the Settings disappears.
> (In reply to Alberto Pastor [:albertopq] from comment #7)
> > Eric, could you please review again? Just was able to repro it and with the
> > latest patch should be fixed. Still see a weird behaviour of the keyboard
> > when appearing, but it happens as well in any other form input (Contacts,
> > for example) on master, so is not related to this patch.

There're two different apps (system & settings) so the patch couldn't affect.

Did you reboot only Gaia after the patch? In that case, the RIL didn't sent the STK menu again so is dropped from the settings tab.
Try rebooting your phone to assure that it's working.

Comment 16

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/7ccded78660543d5cb08357da45fd00e7a0935e6

Comment 17

[Alberto Pastor [:albertopq]]

Comment on attachment 8496793 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24655

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: User is not able to interact with the STK when the soft button is enabled
[Testing completed]: Manual testing. Only changed css (and javascript that changes css).
[Risk to taking this patch] (and alternatives if risky): Low risk. Just calculating the screen height taking into account the softbuton
[String changes made]: -

Comment 18

[Kevin Grandon :kgrandon]

Comment on attachment 8496793 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24655

Not ready for uplift yet.

Comment 19

[Kevin Grandon :kgrandon]

Reverting for now due to having a wrong number against this bug. This causes a lot of problems when trying to track down test failures, as is happening right now. https://github.com/mozilla-b2g/gaia/commit/b04f6bae98b458a69e3a50c1ab7877257ce5cbf6

This may have also caused an integration test failure which I'm investigating. The particular failure I'm looking at is: 

    at processImmediate [as _immediateCallback] (timers.js:330:15)
11:17:34     INFO -    5) Ringtone picker Ringtones picker Set selected sound:
11:17:34     INFO -        + expected - actual
11:17:34     INFO -        +Bubble
11:17:34     INFO -        -Default
11:17:34     INFO -    AssertionError: "Default" === "Bubble"

I will update this bug depending on the outcome of the backout test run.

Comment 20

[Kevin Grandon :kgrandon]

Also *please* make sure you correct the bug number before re-landing.

Comment 21

[Alberto Pastor [:albertopq]]

Comment on attachment 8496793 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24655

https://github.com/mozilla-b2g/gaia/pull/24655

Comment 22

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/923458feb3aabe6b2ebe070d2b1c1ef666ae5c70

Comment 23

[Alberto Pastor [:albertopq]]

Comment on attachment 8496793 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24655

See https://bugzilla.mozilla.org/show_bug.cgi?id=1072728#c17

Comment 24

[Tony Chung [:tchung]]

Eric, can you confirm this bug has been fixed and uplifted to 2.1?

Comment 25

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/68453661554d295b26f9eae8648f3a951feeed9c

Comment 26

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-10-08-11-01-51.png

It looks like there is a thin line between the page and shb.

Gaia-Rev        e9b9ee15eded2671656efbc40f8437ae8a61d55c
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/49bd5bad84d2
Build-ID        20141007170148
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141007.202947
FW-Date         Tue Oct  7 20:29:58 EDT 2014
Bootloader      L1TC00011840

Comment 27

[Eric Chang [:ericcc] [:echang]]

Hi Alberto, Could you take a look, thank you.

Comment 28

[Alberto Pastor [:albertopq]]

Attachment: stk-line.png

Seems to me a KeyboardManager.getHeight bug when the words suggestion is present. Changing the type of the input to email (so the suggestions are not there) it looks fine (see attachment). I tried as well without SHB, and it happens the same. Tim, any idea?

Comment 29

[Tim Guan-tin Chien [:timdream] (please needinfo)]

John, maybe this is related to bug 1059683?

Comment 30

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Actually, we should file another bug for that as two bugs are not related.

Eric?

Comment 31

[John Lu [:mnjul][Please NI or I'll miss]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #29)
> John, maybe this is related to bug 1059683?

Yep, the thin line Alberto talked about can be fixed by uplifting bug 1059683 onto v2.1.

But I can't reproduce what Eric saw [1], and since the screenshot Eric provided did not have a keyboard, I'm not sure if it's related.

[1] With current upstream/v2.1 b3823139d7814f685b7af8674086c00280c43f0e of Gaia,
    and pvt from gecko identified as Build ID 20141008160203 and Gecko-Rev https://hg.mozilla.org/releases/mozilla-aurora/rev/8811060bf3fe

Comment 32

[John Lu [:mnjul][Please NI or I'll miss]]

(In reply to John Lu [:mnjul] [MoCoTPE] from comment #31)
> [1] With current upstream/v2.1 b3823139d7814f685b7af8674086c00280c43f0e of
> Gaia,

Sorry I meant 7e2ef41d3ac98757acaf490b5413fb42061ad3e6 .

Comment 33

[Eric Chang [:ericcc] [:echang]]

Sure, ongoing.
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #30)
> Actually, we should file another bug for that as two bugs are not related.
> 
> Eric?

Comment 34

[Eric Chang [:ericcc] [:echang]]

Gaia-Rev        55ce3612bd8a8665139d6b85114ce59993a3fa0a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/8811060bf3fe
Build-ID        20141008160203
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141008.191730
FW-Date         Wed Oct  8 19:17:41 EDT 2014
Bootloader      L1TC00011840

Comment 35

[Sue]

Hi Hubert,
We have no environment to verify this issue.

Comment 36

[Hubert Lu[:hlu] <[e-mail]>]

This was verified on comment 34, so remove verifyme flag.