Closed Bug 1073010 Opened 5 years ago Closed 5 years ago

No way to directly open in Fennec from the Share overlay

Categories

(Firefox for Android :: Overlays, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 36
Tracking Status
firefox34 --- disabled
firefox35 --- verified
firefox36 --- verified
fennec 34+ ---

People

(Reporter: mfinkle, Assigned: rnewman)

Details

Attachments

(1 file)

There seems to be no way to share from an external application to Fennec and have Fennec open right away.

I assumed that tapping on the Logo or the URL at the top of the overlay would do this, but it doesn't.
tracking-fennec: 34+ → ?
Flags: needinfo?(ywang)
Flags: needinfo?(rnewman)
Flags: needinfo?(chriskitching)
You're right, there's no way to do this at present.

I do like this idea, I'll provide a patch if Yuan thinks it's a good plan - maybe she has some refinements to suggest.
Flags: needinfo?(chriskitching)
Assignee: nobody → chriskitching
tracking-fennec: ? → 34+
Do it. We can refine later.
Flags: needinfo?(rnewman)
OS: Linux → Android
Hardware: x86_64 → All
Though I doubt "Share" is the path for a use to open a link in a separate app, it's fairly easy to do and not adding additional UI.

So I will give a pass on this. I think tapping the logo is a good hidden shortcut to switch to Fennec.
Flags: needinfo?(ywang)
Re-assign?
Assignee: chriskitching → rnewman
Status: NEW → ASSIGNED
Tested on tablet, seems to work fine. I made the top bar (with link) and the Firefox head tappable. The Firefox head on its own seems to be too small of a tap target, or it's not clickable for some other reason, but the top bar catches those clicks.
Attachment #8505091 - Flags: review?(margaret.leibovic)
Comment on attachment 8505091 [details] [diff] [review]
Allow browsing from share overlay. v1

Review of attachment 8505091 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.

::: mobile/android/base/overlays/ui/ShareDialog.java
@@ +26,4 @@
>  import android.widget.TextView;
>  import android.widget.Toast;
>  
> +import org.mozilla.gecko.*;

I think your tools are getting over-eager on the imports here :)
Attachment #8505091 - Flags: review?(margaret.leibovic) → review+
I think that's IntelliJ's default behavior. Already told ckitching off for doing that :)
(In reply to Richard Newman [:rnewman] from comment #7)
> I think that's IntelliJ's default behavior. Already told ckitching off for
> doing that :)

Richard, if you're using IDEA and it's doing this, the appropriate setting to make it stop is under:

Settings -> Code Style -> Java -> Imports (tab)

Change the value of "Class count to use import with *" and "Names count to use import with *" to suitably large numbers.

If you want to prevent IDEA from optimising imports on any file you ever open (which leads to irrelevant chunks in your patch), you'll want to go to Settings -> Editor -> Auto Import and uncheck "Optimise imports on the fly"

Note that if your project is badly configured then IDEA's automatic import system will produce nonsense, notably if you don't have the support library set up right then IDEA will merrily shove in imports for the "real" classes instead of the support library versions.
https://hg.mozilla.org/mozilla-central/rev/8963be45cbf8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Status: RESOLVED → VERIFIED
Comment on attachment 8505091 [details] [diff] [review]
Allow browsing from share overlay. v1

Approval Request Comment
[Feature/regressing bug #]:
  Obvious extension to Send to Firefox.

[User impact if declined]:
  Confounded expectations.

[Describe test coverage new/current, TBPL]:
  Manual testing only.

[Risks and why]: 
  Low risk -- adds a new tap target to the dialog that simply launches the browser. A nice little value-add.

[String/UUID change made/needed]:
  None.
Attachment #8505091 - Flags: approval-mozilla-aurora?
Attachment #8505091 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tapping the top of the dialog from the share overlay, will open the page in browser.
Verified fixed on:
Device: LG Nexus 5 (Android 4.4)
Builds: Firefox for Android 36.0a1 (2014-10-23) and  Firefox for Android 35.0a2 (2014-10-23)
Comment on attachment 8505091 [details] [diff] [review]
Allow browsing from share overlay. v1

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Poorer UX. We were tracking this for Fx34.
[Describe test coverage new/current, TBPL]:
[Risks and why]: Low, has been working fine on Fx36 and Fx35
[String/UUID change made/needed]: None
Attachment #8505091 - Flags: approval-mozilla-beta?
Comment on attachment 8505091 [details] [diff] [review]
Allow browsing from share overlay. v1

Beta+
Attachment #8505091 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Needs rebasing for beta uplift.
Flags: needinfo?(rnewman)
We're very likely not turning the feature on in Beta per Bug 1092409, so clearing the branch request for now.
Flags: needinfo?(rnewman)
You need to log in before you can comment on or make changes to this bug.