1073050 - [pinboard] Previously-entered bug number doesn't get cleared

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

I had to manually enter a bug number on the pinboard (related bugs section) because the failure didn't match any bugs. The submission went through without error and the bug was properly commented.

Later, I went to do the same on a different failure and the previously-entered bug number was still there. I'm thinking it should have been cleared once I saved the earlier one.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Bug 1071240 should have fixed this?

Comment 2

[Ed Morley [:emorley]]

Unless bug 1071240 is not on production & it would also fix this?

Comment 3

[Ed Morley [:emorley]]

Do you still see this?

Comment 4

[Jonathan French (:jfrench)]

I recall fixing a few unrelated bugs, back in July (bug 1045774 and bug 1045611) in this area. At the time I think we just acknowledged that the related-bugs[+] icon when pressed, was caching the last-used bug number. I don't think there was a breakout bug entered at that time.

I'm not sure if camd's fix for bug 1071240 encompassed the related-bugs[+] part of the UI.

I can reproduce this on both Firefox and Chrome in dev also.

Comment 5

[Jonathan French (:jfrench)]

This seems like it could be LHF, so I'll have a look.

Comment 6

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#227

Please see the above PR for review and status.

Comment 7

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/c323b0d801efc905bfbc8eb253e7c7beb1669909
Bug 1073050 - Clear previously entered bug number

https://github.com/mozilla/treeherder-ui/commit/3bdd965e51569de5a4a73cb6135960bd69278019
Merge pull request #227 from tojonmz/clear-bug-number

Bug 1073050 - Clear previously entered bug number

Comment 8

[Jonathan French (:jfrench)]

Verified fixed and working correctly on dev/stage in both Firefox and Chrome.

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3321c249bbda60f651f19b123bb05b186dcbbd19
Bug 1073050 - Clear previously entered bug number

https://github.com/mozilla/treeherder/commit/873066377517b87bd7fc1857873e74b98bae36bb
Merge pull request #227 from tojonmz/clear-bug-number

Bug 1073050 - Clear previously entered bug number