1073066 - Reader mode menu background color is inconsistent with new toolbar grey

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: Screenshot_2014-09-25-10-30-59.png

As per bug 1055536, our Reader Mode has the same issue with different (not matching) greys. Let's clean this up too.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Use consistent grey tone in reader mode (r=margaret)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Comment 3

[Lucas Rocha (:lucasr)]

Fixed the popup divider to have the same color than the button dividers btw.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

That reminds me, the dividers look really blue still. I posted a comment about those here: https://bugzilla.mozilla.org/show_bug.cgi?id=1055536#c21 not sure how easy it would be but it's fairly obvious when there are a lot...

Comment 5

[:Margaret Leibovic]

Comment on attachment 8495846 [details] [diff] [review]
Use consistent grey tone in reader mode (r=margaret)

Review of attachment 8495846 [details] [diff] [review]:
-----------------------------------------------------------------

We'll also need to update the color of the popup arrow:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/images/reader-dropdown-arrow-hdpi.png
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/images/reader-dropdown-arrow-mdpi.png
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/images/reader-dropdown-arrow-xhdpi.png

And it seems to me like we should make sure the horizontal dividers also match the vertical dividers:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/aboutReader.css#399

Comment 6

[:Margaret Leibovic]

NI to antlam to help update the popup arrow images.

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #5)
> Comment on attachment 8495846 [details] [diff] [review]
> Use consistent grey tone in reader mode (r=margaret)
> 
> Review of attachment 8495846 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> We'll also need to update the color of the popup arrow:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/
> images/reader-dropdown-arrow-hdpi.png
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/
> images/reader-dropdown-arrow-mdpi.png
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/
> images/reader-dropdown-arrow-xhdpi.png

Will find this arrow but I have a feeling I'll need to recreate it...

> And it seems to me like we should make sure the horizontal dividers also
> match the vertical dividers:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/
> aboutReader.css#399

YES! :D

Comment 8

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #5)
> Comment on attachment 8495846 [details] [diff] [review]
> Use consistent grey tone in reader mode (r=margaret)
> 
> Review of attachment 8495846 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> We'll also need to update the color of the popup arrow:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/
> images/reader-dropdown-arrow-hdpi.png
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/
> images/reader-dropdown-arrow-mdpi.png
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/
> images/reader-dropdown-arrow-xhdpi.png
> 
> And it seems to me like we should make sure the horizontal dividers also
> match the vertical dividers:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/
> aboutReader.css#399

Nice catches Margaret, thanks!

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: img_downarrow_newgrey.zip

I performed an educated guess at how these icons would be most useful to you guys.. let's try these! :)

But from some studying of these and looking at how we're implementing them, maybe they're not that useful/necessary anymore... thoughts?

Comment 10

[Lucas Rocha (:lucasr)]

Attachment: Use consistent grey tone in reader mode (r=margaret)

Comment 11

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Comment 12

[:Margaret Leibovic]

Comment on attachment 8498217 [details] [diff] [review]
Use consistent grey tone in reader mode (r=margaret)

Review of attachment 8498217 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 13

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Lucas Rocha (:lucasr) from comment #11)
> Created attachment 8498220 [details]
> Screenshot

<3

Comment 14

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/a50ef251a2ab

Comment 15

[Lucas Rocha (:lucasr)]

Comment on attachment 8498217 [details] [diff] [review]
Use consistent grey tone in reader mode (r=margaret)

Approval Request Comment
[Feature/regressing bug #]: bug 1010740
[User impact if declined]: Unpolished UX in reader mode as its color scheme doesn't match the new toolbar style.
[Describe test coverage new/current, TBPL]: Local testing only. Let's bake it in Nightly for a few days and then uplift to Aurora. 
[Risks and why]: Low, just updates a CSS file and a few images. 
[String/UUID change made/needed]: n/a

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a50ef251a2ab

Comment 17

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8498217 [details] [diff] [review]
Use consistent grey tone in reader mode (r=margaret)

Aurora+

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d27794597ff5

Comment 19

[u421692]

Verified as fixed om Firefox 34 Beta 4 and latest Aurora, on Asus Transformer Pad TF300T (Android 4.1.1)