1073113 - ImageClient updates may race on D3D11

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

When setting an image that can't be shared in an ImageClient, we need to copy it into a TextureClient. In the case of D3D11 (and more generally when the texture doesn't have an internal buffer) we should not use a single buffered ImageClient which writes directly into the front buffer, because it breaks the transactional guarantee of layer updates.

Comment 1

[Nicolas Silva [:nical]]

Attachment: use double buffered ImageClient with D3D11.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8495431 [details] [diff] [review]
use double buffered ImageClient with D3D11.

Review of attachment 8495431 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/ClientImageLayer.cpp
@@ +104,5 @@
>        mImageClientTypeContainer = CompositableType::BUFFER_BRIDGE;
>        return mImageClientTypeContainer;
>      }
>  
> +    if (ClientManager()->GetCompositorBackendType() == LayersBackend::LAYERS_D3D11) {

Add a comment about why d3d11 is annoying.

::: gfx/layers/client/ImageClient.cpp
@@ +34,5 @@
>  #include "mozilla/gfx/2D.h"
>  #ifdef MOZ_WIDGET_GONK
>  #include "GrallocImages.h"
>  #endif
> +#include "nsExpirationTracker.h"

Remove this

Comment 3

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d84db3f0c1ab

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d84db3f0c1ab