1073318 - [Text Selection] Cannot cut/copy/paste/selectall after scrolling

Status: RESOLVED DUPLICATE of bug 1090008

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

STR:
1. long-tap text and bubble shows.
2. scrolling
3. tap any of the buttons

Actual:
button doesn't work

Gaia does send mozContentEvent to gecko.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: wip-bug1073318

Maybe we can check return value of dispatch event to determine is this event a valid.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: wip-bug1073318-gaia

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1073318

This issue is because we overwrite DoCommandHelper._event when we receive a selection change event. If we have multiple BrowserElementParent and send selection change simultaneously then doCommand might send command to wrong BEP.

This patch create a unique id for each BEP so we can distinguish where is this selection change coming from. So we can get rid of DoCommandHelper.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1073318-gaia.patch

Patch for gaia

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 8510030 [details] [diff] [review]
bug1073318

Review of attachment 8510030 [details] [diff] [review]:
-----------------------------------------------------------------

Mostly nits, but we also need new tests before landing.

::: dom/browser-element/BrowserElementParent.jsm
@@ +59,5 @@
>    }
>  }
>  
>  this.BrowserElementParentBuilder = {
> +  id: 0,

nit: _id to be consistent with BrowserElementParent

@@ +66,4 @@
>    }
>  }
>  
> +function BrowserElementParent(frameLoader, hasRemoteFrame, id, isPendingFrame) {

please don't change parameters order.

@@ +497,5 @@
>      }
>    },
>  
>    _handleSelectionChange: function(data) {
> +    data.json.bepid = this._id;

I don't like bepid - this is leaking an implementation detail to gaia. Can we name that just "id" or "uid" ?

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Browser element is re-writing in bug 1044736. So I'll update my patch base on that bug.

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1073318 v2

Based on bug 1044736.

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: bug1073318-test

Mochitest for this feature.

Comment 9

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

I'll request for reviews once bug 1044736 is done.

Comment 10

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Add mochitest.

Comment 11

[Peter Chang[:pchang]]

This should be fixed by bug 1090008. George, could you help to confirm it?

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Yes, confirmed. Mark it as dup of bug 1090008.