1073457 - [Text selection] Selection carets does not work on browser with e10s

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P4)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

SelectionCarets::LaunchLongTapDetector() early returns in [1].

   874   if (XRE_GetProcessType() != GeckoProcessType_Default) {
   875     return;
   876   }

XRE_GetProcessType() returns GeckoProcessType_Content.

[1] http://hg.mozilla.org/mozilla-central/file/5e704397529b/layout/base/SelectionCarets.cpp#l874

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Launch long tap detector when APZ isn't enabled.

LaunchLongTapDetector() is used to fire long tap to select word when
async pan zoom is not enabled. We should check if async pan zoom is
enabled rather than check whether it's on main process.

This can also fix selection carets not working on e10s.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8519703 [details] [diff] [review]
Launch long tap detector when APZ isn't enabled.

Review of attachment 8519703 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/SelectionCarets.cpp
@@ +119,5 @@
>      return;
>    }
>  
> +  docShell->GetAsyncPanZoomEnabled(&mAsyncPanZoomEnabled);
> +

Looks like this function doesn't care about "layers.async-pan-zoom.enabled". So maybe we should do this:

docShell->GetAsyncPanZoomEnabled(&mAsyncPanZoomEnabled);
mAsyncPanZoomEnabled = mAsyncPanZoomEnabled && gfxPrefs::AsyncPanZoomEnabled();

What do you think?

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Agree. We should check gfxPrefs::AsyncPanZoomEnabled().

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Launch long tap detector when APZ isn't enabled. f=mtseng, r=roc (v2)

LaunchLongTapDetector() is used to fire long tap to select word when
async pan zoom is not enabled. We should check if async pan zoom is
enabled rather than check whether it's on main process.

This can also fix selection carets not working on e10s.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Try result:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f33c2bdf431d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ddd2d760589

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ddd2d760589