Closed Bug 1073478 Opened 10 years ago Closed 10 years ago

IonMonkey SIMD: commute SIMD binary operations.

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: dougc, Assigned: sunfish)

References

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attached patch Commute SIMD binary operations. (obsolete) — Splinter Review
Sorry forgot which patch you attached this too, and perhaps it stands alone anyway. Looks like this patch would be useful to land?
Flags: needinfo?(sunfish)
Yes, SIMD arithmetic instructions have the same need as scalar arithmetic instructions on x86, so this commuting heuristic should also be beneficial. I'll propose it for review soon.
Assignee: nobody → sunfish
Flags: needinfo?(sunfish)
We can commute binary operators and comparisons.
Attachment #8495894 - Attachment is obsolete: true
Attachment #8497130 - Flags: review?(benj)
This patch depends on the patch in bug 1074509 for the MSimdBinaryComp::reverse function.
Depends on: 1074509
Comment on attachment 8497130 [details] [diff] [review]
simd-commute.patch

Review of attachment 8497130 [details] [diff] [review]:
-----------------------------------------------------------------

MSimdBinaryBitwise is always commutative too, right? rs=me if you do it the same way as in SimdBinaryArith lowering.
Attachment #8497130 - Flags: review?(benj) → review+
Good catch. I added code for MSimdBinaryBitwise too.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e21f888f27b4
https://hg.mozilla.org/mozilla-central/rev/e21f888f27b4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.