1073534 - "cancel" is a non-localizable string in the audio output picker

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: Non-localisable string with Spanish - 2.1 - Screenshot

Build info
Gaia-Rev        6a6ed9433fce47e76c07fd35bc5952acb108f4c8
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/7b09a378588c
Build-ID        20140926000202
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140926.033610
FW-Date         Fri Sep 26 03:36:21 EDT 2014
Bootloader      L1TC10011800

Prerequisite
Have a BT handset connected.
Have the phone in another language (like French or Spanish)

STR
1. Place a call
2. Tap the headset button 

Actual result
"cancel" is not translated. See attached screenshot for details.

Additionnal info
NO repro on 2.0:
Gaia-Rev        87ee41fcb3f9a14d7a8bb67f1dd7fd95a6bcd0f0
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/b1cb27078909
Build-ID        20140925000206
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140925.032857
FW-Date         Thu Sep 25 03:29:07 EDT 2014
Bootloader      L1TC10011800

[Blocking Requested - why for this release]: Regression +  Non-localizable strings

Comment 1

[Johan Lorenzo [:jlorenzo]]

Regression window wanted.

Comment 2

[Johan Lorenzo [:jlorenzo]]

REPRO on 2.2 ("cancel" is still displayed):
Gaia-Rev        a06714c555ca7068545f10b4437a16c14cd8e7f5
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/9e3d649b80a2
Build-ID        20140926040203
Version         35.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140926.072807
FW-Date         Fri Sep 26 07:28:18 EDT 2014
Bootloader      L1TC10011800

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: (master/v2.2) Add "cancel" string to dialer.

PR: https://github.com/mozilla-b2g/gaia/pull/24481

Comment 4

[Doug Sherk (:drs) (inactive)]

Attachment: (v2.1) Include Contacts properties files in Callscreen to get their "cancel" keys.

PR: https://github.com/mozilla-b2g/gaia/pull/24482

Comment 5

[Doug Sherk (:drs) (inactive)]

master: https://github.com/mozilla-b2g/gaia/commit/19d33962bdab24acadc22d3e3d07a8ec0bed5fe9
v2.1: https://github.com/mozilla-b2g/gaia/commit/ef09dd5b4b2f1ff3fa37ff305ee40d3b918e9dc9

Comment 6

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8496054 [details] [diff] [review]
(v2.1) Include Contacts properties files in Callscreen to get their "cancel" keys.

Sorry, I forgot to ask for approval before landing this. I'll back it out if we don't get it soon.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not known, we didn't need the regression-window.
[User impact] if declined: "Cancel" button on callscreen will not be localized.
[Testing completed]: Anthony and I tested this.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None. Included contacts locales from callscreen.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: non-localizable string.

Comment 8

[KTucker [:KTucker][Inactive 3/4/2016]]

This is verified as fixed on the Flame 2.1 

The word "Cancel" is translated properly.

Flame 2.1 

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

-------------------------------------------------------------------------

This issue is not fixed and still occurring on the Flame 2.2 

The word "Cancel" is not translated for multiple languages.

Flame 2.2 

Device: Flame 2.2 Master  KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

A new bug was written bug 1081745