Closed Bug 1073761 Opened 10 years ago Closed 10 years ago

Intermittent test_value_storage.html | Test timed out.

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- wontfix
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: KWierso, Assigned: gbrown)

References

Details

(Keywords: intermittent-failure)

https://tbpl.mozilla.org/php/getParsedLog.php?id=49013475&tree=Fx-Team Android 2.3 Emulator fx-team opt test mochitest-16 on 2014-09-26 16:10:14 PDT for push 6b3b254b408c slave: tst-linux64-spot-540 17:08:32 INFO - 67 INFO TEST-START | /tests/layout/style/test/test_transitions_events.html 17:08:32 INFO - 68 INFO TEST-OK | /tests/layout/style/test/test_transitions_events.html | took 10692ms 17:08:32 INFO - 69 INFO TEST-START | /tests/layout/style/test/test_transitions_step_functions.html 17:08:32 INFO - 70 INFO TEST-OK | /tests/layout/style/test/test_transitions_step_functions.html | took 4469ms 17:08:32 INFO - 71 INFO TEST-START | /tests/layout/style/test/test_unclosed_parentheses.html 17:08:32 INFO - 72 INFO TEST-OK | /tests/layout/style/test/test_unclosed_parentheses.html | took 10893ms 17:08:32 INFO - 73 INFO TEST-START | /tests/layout/style/test/test_units_angle.html 17:08:32 INFO - 74 INFO TEST-OK | /tests/layout/style/test/test_units_angle.html | took 3654ms 17:08:32 INFO - 75 INFO TEST-START | /tests/layout/style/test/test_units_frequency.html 17:08:32 INFO - 76 INFO TEST-OK | /tests/layout/style/test/test_units_frequency.html | took 2713ms 17:08:32 INFO - 77 INFO TEST-START | /tests/layout/style/test/test_units_length.html 17:08:32 INFO - 78 INFO TEST-OK | /tests/layout/style/test/test_units_length.html | took 3051ms 17:08:32 INFO - 79 INFO TEST-START | /tests/layout/style/test/test_units_time.html 17:08:32 INFO - 80 INFO TEST-OK | /tests/layout/style/test/test_units_time.html | took 2895ms 17:08:32 INFO - 81 INFO TEST-START | /tests/layout/style/test/test_value_storage.html 17:08:32 INFO - 82 INFO TEST-OK | /tests/layout/style/test/test_value_storage.html | took 872644ms 17:08:32 INFO - 83 INFO TEST-UNEXPECTED-FAIL | /tests/layout/style/test/test_value_storage.html | Test timed out. - expected PASS 17:08:32 INFO - 84 INFO TEST-UNEXPECTED-FAIL | /tests/layout/style/test/test_value_storage.html | Test timed out. - Result logged after SimpleTest.finish() 17:08:32 INFO - 85 INFO TEST-START | /tests/layout/style/test/test_variable_serialization_computed.html 17:08:32 INFO - 86 INFO TEST-OK | /tests/layout/style/test/test_variable_serialization_computed.html | took 8559ms 17:08:32 INFO - 87 INFO TEST-START | /tests/layout/style/test/test_variable_serialization_specified.html 17:08:32 INFO - 88 INFO TEST-OK | /tests/layout/style/test/test_variable_serialization_specified.html | took 8470ms 17:08:32 INFO - 89 INFO TEST-START | /tests/layout/style/test/test_variables.html 17:08:32 INFO - 90 INFO TEST-OK | /tests/layout/style/test/test_variables.html | took 6456ms 17:08:32 INFO - 91 INFO TEST-START | /tests/layout/style/test/test_video_object_fit.html 17:08:32 INFO - 92 INFO TEST-OK | /tests/layout/style/test/test_video_object_fit.html | took 3789ms 17:08:32 INFO - 93 INFO TEST-START | /tests/layout/style/test/test_viewport_units.html 17:08:32 INFO - 94 INFO TEST-OK | /tests/layout/style/test/test_viewport_units.html | took 4439ms 17:08:32 INFO - 95 INFO TEST-START | /tests/layout/tables/test/test_bug337124.html 17:08:32 INFO - 96 INFO TEST-OK | /tests/layout/tables/test/test_bug337124.html | took 4208ms 17:08:32 INFO - 97 INFO TEST-START | /tests/layout/tables/test/test_bug541668_table_event_delivery.html 17:08:32 INFO - 98 INFO TEST-OK | /tests/layout/tables/test/test_bug541668_table_event_delivery.html | took 3271ms
:dholbert - In bug 1041075, there was a similar timeout in test_value_storage.html on Android 2.3; you got around that by requesting a longer timeout: http://hg.mozilla.org/mozilla-central/annotate/4fb7ff694bf5/layout/style/test/test_value_storage.html#l316 We are up to 20 minutes now for this test. That still seems fine on Android 2.3. The newer Android 4.3 platform usually exhibits similar performance to Android 2.3, but there are exceptions -- this test seems to be one. Do you have a sense of whether we should simply increase the timeout again, or take some other action (split the test, skip on Android, etc.)?
Flags: needinfo?(dholbert)
See Also: → 1041075
The "real" fix for this test is probably to fix bug 1045205, which is about the slowdown in bug 1041075. For a stopgap to avoid hitting this though: I guess we should just increase the timeout again, using .requestLongerTimeout(5). rs=me if you want to land a patch to do that. It'd be nice if we could do that *just* for this Android 4.3 platform, but I don't know if that's easy, and it's probably not necessary. This test & its timeout aren't intended to be a performance test; the mochitest timeout is just a threshold for "if a test ran longer than this amount of time, then it's likely to have hanged"; and in this case, we need a large threshold apparently, because the test really does take this long (and isn't hanging). (It might be possible to split up the test, but it would probably some careful architecting to make sure we're not losing test coverage & not making things more complex. I definitely don't think we should split it in such a way where we test some CSS properties in test1 and test the rest of the properties in test2. But it's conceivable that the stuff that we're actually testing on each property could be subdivided into separate tests, carefully.)
Flags: needinfo?(dholbert)
Assignee: nobody → gbrown
https://hg.mozilla.org/mozilla-central/rev/a3f95ced1f7e
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Blocks: 1238840
Blocks: 1244978
See Also: → 1317732
Blocks: 1318393
You need to log in before you can comment on or make changes to this bug.