1073965 - Selected columns in Storage Inspector's tables should persist/be remembered

Status: NEW

(DevTools :: Storage Inspector, enhancement, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox Nightly and Aurora 20140928 on Windows 8.1

The columns of the storage inspector when inspecting e.g. cookies don't show all of them by default, the context menu offers 3 additional columns. Everytime you open the Storage Inspector, you have to manually enable this columns. The last selected set of columns should persist.

Comment 1

[ddpm]

Bug still within Firefox 50.0.2

I was using Firebug plugin until now where the isSecure column was shown by default or at least remembered the column setting(cant remember if was default)

But now as Firebug and Developer Tools are merged with Firefox 50, it is quite annoying to not having the isSecure column visible by default. I can enable that column by context menu, but the setting is not persistent (select for example **Indexed DB** or **Local Storage** area and go back to **Cookies** area - bam! - isSecure column is gone)

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

It is clear that the state of each column should be remembered. I have added this to bug 1312444 to get this fixed more quickly.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on Brobdingnagian.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on HOTFROG.

Comment 5

[April King [:April]]

It would be really nice if we could fix this for 57. The "Secure" column is hidden by default, when it should probably be default. Having to enable it every time I work with the Storage Inspector is one of the more frustrating behaviors inside dev tools.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Let's keep a list of visible columns in the pref `devtools.storage.columns`

{
  cookies: [name, domain, path],
  ...
}

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: [WIP] 1073965-storage-remember-column-settings.diff

WIP patch... this approach doesn't work because we have no access to prefs from the content process. It probably makes more sense to move this into the table widget, which can have it's own preference.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Rather than using prefs we could use our async-storage module:

 * To store a value use setItem:
 *
 *   asyncStorage.setItem("key", "value");
 *
 * This returns a promise in case you want confirmation that the value has been stored.
 *
 *  asyncStorage.setItem("key", "newvalue").then(function() {
 *    console.log("new value stored");
 *  });
 *
 * To read a value, call getItem(), but note that you must wait for a promise
 * resolution for the value to be retrieved.
 *
 *  asyncStorage.getItem("key").then(function(value) {
 *    console.log("The value of key is:", value);
 *  });
 *
 * Note that unlike localStorage, asyncStorage does not allow you to store and
 * retrieve values by setting and querying properties directly. You cannot just
 * write asyncStorage.key; you have to explicitly call setItem() or getItem().
 *
 * removeItem(), clear(), length(), and key() are like the same-named methods of
 * localStorage, and all return a promise.

Examples:

const asyncStorage = require("devtools/shared/async-storage");

let customColors = await asyncStorage.getItem("gridInspectorHostColors") || {};
await asyncStorage.setItem("gridInspectorHostColors", customGridColors);
await asyncStorage.removeItem(LOCAL_DEVICES);
let length = await asyncStorage.length();
ley key = await asyncStorage.key(0);
await asyncStorage.clear;

Comment 9

[Patrick Brosset <:pbro>]

This bug has not been updated in the last 6 months. Resetting the assignee field.
Please, feel free to pick it up again and add a comment outlining your plans for it if you do still intend to work on it.
This is just trying to clean our backlog of bugs and make bugs available for people.

Comment 10

[ddpm]

Bug still within Firefox 92 😢