Closed Bug 1073978 Opened 9 years ago Closed 9 years ago
when tab changes "remoteness", tab events stop working (e10s)
46 bytes, text/x-github-pull-request
|Details | Review|
when tab changes "remoteness", tab's browser is destroyed (and another one re-created), so all the MessageListeners go away with it: https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/tabs/tab-firefox.js#L65
> when tab changes "remoteness" this can happen upon navigation from a remote page to a non-remote one, or vice-versa (XUL, chrome-privileged and possibly some other types of pages are not "remotable").
no events for this, since this is to fix existing tests in e10s mode (will enable them later).
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
Attachment #8496595 - Flags: review?(dtownsend+bugmail)
(In reply to Tomislav Jovanovic [:zombie] from comment #2) > no events for this "no new tests for this"
Summary: when tab changes "remoteness", events stop working (e10s) → when tab changes "remoteness", tab events stop working (e10s)
Attachment #8496595 - Flags: review?(dtownsend+bugmail) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/e89618a7a3c08c7147d8858cd4c838423c2b8625 bug 1073978 - use parent messageManager for tab events https://github.com/mozilla/addon-sdk/commit/6f5a03bd8334e45b78c387492e9b35809d18c9d8 Merge pull request #1662 from zombie/1073978-remoteness-change bug 1073978 - use parent window.messageManager for tab events, r=@Mossop
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.