1074004 - Update nestegg from upstream

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Import latest libnestegg from upstream to sync the sources.  Only significant change is libnestegg now does internal buffering to reduce read overhead caused by its byte-at-a-time parser.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: bug1074004_v0.patch

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: bug1074004_webmwriter_v0.patch

The internal buffering changes revealed a couple of bugs in TestWebMWriters WebMioData implementation:

- Seek should return 0 on success
- Reading past the end of stream should return EOS rather than an error

Comment 3

[Matthew Gregan [:kinetik]]

https://tbpl.mozilla.org/?tree=Try&rev=bcbd795fa2f7

Comment 4

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/571cef4dcf52
https://hg.mozilla.org/integration/mozilla-inbound/rev/2af5453da3ab

Comment 5

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/405b97368630

Comment 6

[Carsten Book [:Tomcat]]

tests were still failing after the bustage fix so i had to backout this 3 changes for ongoing test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=49168555&tree=Mozilla-Inbound - sorry!

Comment 7

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27bcbf49cfd7
https://hg.mozilla.org/integration/mozilla-inbound/rev/5997c0f393ba

Comment 8

[Matthew Gregan [:kinetik]]

Sorry, I tested the bustage fix locally but accidentally used a --disable-debug tree, so the assert didn't fire.  Correct fix included in latest push.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/27bcbf49cfd7
https://hg.mozilla.org/mozilla-central/rev/5997c0f393ba