Closed Bug 1074004 Opened 7 years ago Closed 7 years ago

Update nestegg from upstream

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(2 files)

Import latest libnestegg from upstream to sync the sources.  Only significant change is libnestegg now does internal buffering to reduce read overhead caused by its byte-at-a-time parser.
Attachment #8496628 - Flags: review?(giles)
The internal buffering changes revealed a couple of bugs in TestWebMWriters WebMioData implementation:

- Seek should return 0 on success
- Reading past the end of stream should return EOS rather than an error
Attachment #8496629 - Flags: review?(giles)
Attachment #8496628 - Flags: review?(giles) → review+
Attachment #8496629 - Flags: review?(giles) → review+
tests were still failing after the bustage fix so i had to backout this 3 changes for ongoing test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=49168555&tree=Mozilla-Inbound - sorry!
Sorry, I tested the bustage fix locally but accidentally used a --disable-debug tree, so the assert didn't fire.  Correct fix included in latest push.
https://hg.mozilla.org/mozilla-central/rev/27bcbf49cfd7
https://hg.mozilla.org/mozilla-central/rev/5997c0f393ba
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Depends on: 1077086
Depends on: 1078118
You need to log in before you can comment on or make changes to this bug.