1074006 - Get Thunderbird to launch with the new .app bundle structure

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

Port of bug 1050944

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

I won't be able to drive this patch and land it.

Comment 2

[Robert Strong (they/them - no direct email)]

Another patch for v2 signing

Comment 3

[Josiah Bruner [:jsbruner]]

needinfoing myself so I don't miss this.

Comment 4

[Josiah Bruner [:jsbruner]]

Patch looked good, just a few minor things (which I corrected) and TB seems to be launching again! Thanks Robert!

https://hg.mozilla.org/comm-central/rev/86199339bfe8

Comment 5

[Josiah Bruner [:jsbruner]]

Hmm, apparently you didn't set an HG User on that patch, so it landed with my name. Sorry about that, didn't mean to steal credit!

Comment 6

[Robert Strong (they/them - no direct email)]

I'm perfectly fine with that and no worries whatsoever. Actually Stephen did the original work and I just ported over the changes.

Comment 7

[Josiah Bruner [:jsbruner]]

Reopened because of Linux bustage. Looks simple enough: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=307&repo=comm-central

I'll look at it in detail tonight.

Comment 8

[Nomis101]

(In reply to Josiah Bruner [:JosiahOne] from comment #7)
> Reopened because of Linux bustage. Looks simple enough:
> https://treeherder.mozilla.org/ui/logviewer.html#?job_id=307&repo=comm-
> central
> 
> I'll look at it in detail tonight.

In the new patch you could also include the code cleanup from Bug 1077282 into nsMailApp.cpp

-    nsCOMPtr<nsIFile> parent;
-    greDir->GetParent(getter_AddRefs(parent));
-    greDir = parent.forget();
-    greDir->AppendNative(NS_LITERAL_CSTRING(kOSXResourcesFolder));
+    greDir->SetNativeLeafName(NS_LITERAL_CSTRING(kOSXResourcesFolder));

https://hg.mozilla.org/mozilla-central/rev/9c87dcd65628

Comment 9

[Philip Chee]

(In reply to Josiah Bruner [:JosiahOne] from comment #7)
> Reopened because of Linux bustage. Looks simple enough:
> https://treeherder.mozilla.org/ui/logviewer.html#?job_id=307&repo=comm-
> central
> 
> I'll look at it in detail tonight.

Robert missed this out (needed for Linux):
https://hg.mozilla.org/mozilla-central/rev/f438f50b8bb3#l2.19
> +#include <unistd.h>

You might need the makefile changes too.

Comment 10

[Josiah Bruner [:jsbruner]]

Attachment: fixLaunching.patch

Now this doesn't break Linux. I'm carrying the review flags because Robert and myself have worked on this.

Comment 11

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/817bad162ea9

Comment 12

[Philip Chee]

(In reply to Josiah Bruner [:JosiahOne] from comment #11)
> https://hg.mozilla.org/comm-central/rev/817bad162ea9
You forgot about comment 8

Comment 13

[Josiah Bruner [:jsbruner]]

Oh, yes. I'll write up a followup patch.

Comment 14

[Josiah Bruner [:jsbruner]]

Attachment: Cleanup followup

Here's the cleanup portion.

Comment 15

[Josiah Bruner [:jsbruner]]

Comment on attachment 8504271 [details] [diff] [review]
fixLaunching.patch

[Approval Request Comment]
Regression caused by (bug #): V2 Codesigning
User impact if declined: 
Testing completed (on c-c, etc.): On c-c
Risk to taking this patch (and alternatives if risky):

Comment 16

[Philip Chee]

Comment on attachment 8504901 [details] [diff] [review]
Cleanup followup

Looks good r=me

Comment 17

[Josiah Bruner [:jsbruner]]

Cleanup patch landed on c-c: https://hg.mozilla.org/comm-central/rev/cb0d7be5a15c

Comment 18

[Josiah Bruner [:jsbruner]]

Patches landed on c-a: 

https://hg.mozilla.org/releases/comm-aurora/rev/319ab9965c81
https://hg.mozilla.org/releases/comm-aurora/rev/e5dd01e8191d

Comment 19

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/636f13c852c8
https://hg.mozilla.org/releases/comm-beta/rev/6e7d4fce8a59