1074069 - [Messages] If we get an error when the user tries to send, check if PIN is required

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect, P3)

Description

[Julien Wajsberg [:julienw]]

STR:
1. Have a device with a SIM that has SIM security enabled (with PIN)
2. Always use "skip" when the PIN dialog is displayed
3. Starts the Messages app (use "skip" again)
4. Try to send a message

Actual:
* An error message is displayed, but the error message is invalid as it says the SIM is invalid. It does not say anything about the PIN required state.

Expected:
* The error message says something about the PIN required state.

Comment 1

[Mike Hoye [:mhoye]]

I bet if we had a link to the source where this fix would go and a mentor, this could be a good first bug.

Comment 2

[Julien Wajsberg [:julienw]]

Actually I'm not so sure. I don't know if we have the right permissions to look the state, where to look the state, and the error handling code is not so easy.

Comment 3

[Steve Chung [:steveck]]

Hi Bevis, is it possible to expose more information by firing another error message(or possibility to classify the reason of invalid SIM state)?

Comment 4

[Steve Chung [:steveck]]

I saw your reply in bug 1070476... Maybe we should move the discussion here?

Comment 5

[Jenny Lee]

Hello, the logical behavior should be

1. Have a device with a SIM that has SIM security enabled (with PIN)
2. Open Message 
3. Don't show PIN code screen, user can do anything except actions that requires the use of SIM
4. User tries to do something that requires the use of SIM like send message
5. Show PIN code enter screen with explanation that in order to send message, correct SIM PIN is needed
6. PIN unlocked, continue message sending process

(the same should go with apps that uses SIM)

Is this feasible?

Comment 6

[Jenny Lee]

ni Julien :)

Comment 7

[Julien Wajsberg [:julienw]]

Jenny, in this bug, my goal was to have something very lighter: just display an appropriate error message when this happens.

What you propose is definitely where we need to go long-term, but this needs discussions with System peers and Gecko developers... I don't know the current logic to display the PIN panel.
We can file a separate bug for this long-term solution, and NI some right persons and/or start a thread on dev-gaia.

Comment 8

[Jenny Lee]

Ok, in that case, I think an updated string would be enough:

To send message, please unlock SIM PIN first.
[Ok]

ni Matej for string review. Please see comment 0 for where the message appears, thanks Matej!

Comment 10

[Josh Cheng [:josh]]

Triage:
Gary, Could you please have a check?

Comment 11

[Matej Novak [:matej]]

(In reply to Jenny Lee from comment #8)
> Ok, in that case, I think an updated string would be enough:
> 
> To send message, please unlock SIM PIN first.
> [Ok]
> 
> ni Matej for string review. Please see comment 0 for where the message
> appears, thanks Matej!

I would make it:

To send your message, please enter your SIM PIN.
[OK]

How does that sound?

Comment 12

[Julien Wajsberg [:julienw]]

Hey Matej, it sounds weird because this dialog would not have anything to enter the SIM PIN.
Actually we should definitely explain how to enter the SIM PIN in that case. For example, pressing "home" and entering the Messages app again works.

Comment 13

[Matej Novak [:matej]]

(In reply to Julien Wajsberg [:julienw] (PTO until 7th October, ask :steveck or :azasypkin for SMS stuff) from comment #12)
> Hey Matej, it sounds weird because this dialog would not have anything to
> enter the SIM PIN.
> Actually we should definitely explain how to enter the SIM PIN in that case.
> For example, pressing "home" and entering the Messages app again works.

I really don't know anything about how this works, I was just editing the proposed text in comment 8.

Can you give me an idea of what you think it should say/communicate?

Comment 14

[Julien Wajsberg [:julienw]]

I'd do something like:

To send message, please unlock SIM PIN first by pressing Home and entering the Messages application again.

Comment 15

[Sean Lee [:seanlee][:weilonge]]

Attachment: screenshot for missing sim card in sms

Comment 16

[Sean Lee [:seanlee][:weilonge]]

(In reply to Julien Wajsberg [:julienw] (PTO until 7th October, ask :steveck or :azasypkin for SMS stuff) from comment #14)
> I'd do something like:
> 
> To send message, please unlock SIM PIN first by pressing Home and entering
> the Messages application again.

Hi Julien,

It shows the same message (as below) in two phones which are without SIM card or skipping SIM code input.
sendMissingSimCardTitle     = Missing SIM card
sendMissingSimCardBody      = Insert a valid SIM card to continue.

I think the message should be able to handle the both cases.
So we can only modify the messages without adding error handling codes.

The message may be like this:
 Title: Invalid SIM card
  Body: Please insert a valid SIM card or unlock PIN code to continue.

The index of i18n message (sendMissingSimCardTitle, sendMissingSimCardBody) should be modified as well.

Comment 17

[Sean Lee [:seanlee][:weilonge]]

ni Julien  :)

Comment 18

[Sean Lee [:seanlee][:weilonge]]

sorry to ni wrong person.

Comment 19

[Julien Wajsberg [:julienw]]

It's really a question for Jenny :)

IMO if it's possible to distinguish the 2 cases, I think we should do it. But if Jenny is OK with this yet simpler solution then I'm OK too.

Comment 20

[Luke Chang [:lchang] (inactive)]

Hi Josh,

I'm afraid that there isn't enough time to do localization if we change the string in 2.0m branch at this moment. Could you please help me confirm that? Thanks.

Comment 21

[Evelyn Hung]

So if our decision here is changing error message to fix this issue, then we definitely need localization team aware this late string change. Another way is informing partner so they can deal with the translation.
Josh, I think what we need here is internal communication withe l10n team, or external communication with partner.

Comment 22

[Evelyn Hung]

also ni stas (l10n team) for his opinion.

Comment 23

[Matej Novak [:matej]]

Not sure where all of this leaves us, but I'll comment on the copy in comment 16:

> Title: Invalid SIM card
> Body: Please insert a valid SIM card or unlock PIN code to continue.

Is it accurate to say that you're unlocking the PIN? Aren't you unlocking the SIM with the PIN?

Also, we don't need "code" after "PIN."

I would say:

Title: Invalid SIM card
Body: Please insert a valid SIM card or enter PIN to continue.

Comment 24

[Jenny Lee]

(In reply to Julien Wajsberg [:julienw] from comment #19)
> It's really a question for Jenny :)
> 
> IMO if it's possible to distinguish the 2 cases, I think we should do it.
> But if Jenny is OK with this yet simpler solution then I'm OK too.

It's definitely better to handle two different cases separately from UX point of view.

So for the case where user needs to enter PIN, we show dialog:

To send your message, please enter SIM PIN first by pressing Home and entering the Messages application again.
[OK]

For the case where SIM card is not valid or missing:

To send your message, please insert a valid SIM card.
[OK]

ni Matej. Thanks a lot Matej :)

Comment 25

[Staś Małolepszy :stas]

Forwarding the needinfo to flod, who knows much more about the l10n timings than I do.

Comment 26

[Matej Novak [:matej]]

(In reply to Jenny Lee from comment #24)
> (In reply to Julien Wajsberg [:julienw] from comment #19)
> > It's really a question for Jenny :)
> > 
> > IMO if it's possible to distinguish the 2 cases, I think we should do it.
> > But if Jenny is OK with this yet simpler solution then I'm OK too.
> 
> It's definitely better to handle two different cases separately from UX
> point of view.
> 
> So for the case where user needs to enter PIN, we show dialog:
> 
> To send your message, please enter SIM PIN first by pressing Home and
> entering the Messages application again.
> [OK]

I don't think we need the word "first"

To send your message, please enter your SIM PIN by pressing Home and entering the Messages application again.
[OK]

> For the case where SIM card is not valid or missing:
> 
> To send your message, please insert a valid SIM card.
> [OK]

+1

> ni Matej. Thanks a lot Matej :)

Thanks.

Comment 27

[Axel Hecht [:Pike]]

This is in an offline conversation right now, we'll update when that thread has closure.

Comment 28

[Josh Cheng [:josh]]

Base on this is not trivial fix and not partner blocker.
Mark to 2.0M? and Triage again tomorrow with TAM.

Comment 29

[Francis Lee [:frlee]]

triage: it's not partner blocker, considering the risk and impact.

Comment 30

[Evelyn Hung]

nominate it for 2.2

Comment 31

[Julien Wajsberg [:julienw]]

Filed bug 1079690 for reworking how displaying the PIN panel works currently.

Comment 32

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: it's a feature. I'll nominate to feature-b2g and let product decide.

Comment 33

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Tracking Requested - why for this release]:

not in 2.2 must-have scope.

Comment 34

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 35

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(