1074208 - Tweak tab curve

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Make it smoother.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Tweak curve shape (r=mcomella)

Comment 2

[Lucas Rocha (:lucasr)]

Here's an APK with the patch.
https://dl.dropboxusercontent.com/u/1187037/new-new-curve01.apk

I have to say, I'm not happy with this change on phones. We're pretty much back to where we were before the initial curve change: the curve takes too much space for no good reason.

The new curve looks nicer on tablets though.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks for pulling this build together Lucas!

Yeah, I'm going to have to say this doesn't look as good on a small screen. I especially notice the top of the curve looking very 'wavy' because the control point's so far away. This is even more evident if we take into account the fading status bar, or any accent color status bar that might be possible with Android L.

I think the main issue with the current one is the visible "straight line" that exists in the center of the curve causing it to not look "smoother". This was largely an effect of saving more space in an already cramped situation. I'm not sure how But, acknowledging that while coming up with a better long term solution for the curve overall seems like the better solution here.

For V1, let's stick with what we have and see what alternatives we can present in the long run. Maybe even address the "straight line" if we have time as a part of a minor change. But, I've already begun drawing up a presentation to see what are some bigger improvements we can make to the Toolbar as a part of V2/V3 of this project.

Comment 4

[Lucas Rocha (:lucasr)]

I agree. Maybe a bit part of V2/V3 should be about coming up with a good solution for bug 1074220 instead of tweaking this curve again. Closing this bug for now.