Using space bar to add a job to the pin board occasionally just submits the classification for that job

RESOLVED FIXED

Status

Tree Management
Treeherder
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: KWierso, Assigned: camd)

Tracking

Details

(Reporter)

Description

3 years ago
I don't have really good steps to reproduce this consistently, but I've been having this happen occasionally while using treeherder for sheriffing last week. I think it's some combination of manually typing something into the classification textbox on one failure, then clicking the "Save" button to submit the classification, then moving on to a new failure and pressing the space bar to add it to the pinboard. 

It almost seems like the "Save" button is stealing focus, so that when I press the space bar, that's simultaneously adding the new failure to the pinboard and calling the "Save" button's action against it.
I've run into this as well.
Blocks: 1059400

Updated

3 years ago
Blocks: 1059368

Comment 2

3 years ago
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #1)
> I've run into this as well.

Me too
Priority: -- → P1
(Assignee)

Updated

3 years ago
Assignee: nobody → cdawson

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
ok, I can reproduce this.  if the "save" button has focus, (like you tabbed to it) then clicking space will act as a click.  There are probably several ways you can get focus on that, some platform specific.  So I will disable "save" whn you hit spacebar.
(Reporter)

Comment 4

3 years ago
(In reply to Cameron Dawson [:camd] from comment #3)
> ok, I can reproduce this.  if the "save" button has focus, (like you tabbed
> to it) then clicking space will act as a click.  There are probably several
> ways you can get focus on that, some platform specific.  So I will disable
> "save" whn you hit spacebar.

I think better than disabling spacebar's action when "save" is focused would be to explicitly unfocus/blur after the "save" button has been clicked or otherwise activated? Spacebar to activate a button is probably good for accessibility if it's happening intentionally.

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/4d7c1d6e44d4098b6247b8b0236523df5dd9c17a
Bug 1074239 - prevent classify save on spacebar

https://github.com/mozilla/treeherder-ui/commit/618f19c2b1167038ce2f84c63d77ea7a89cf4d65
Bug 1074239 - fix icon height on save button

https://github.com/mozilla/treeherder-ui/commit/b8e29be138c2f65494914924939ea6a0f389d097
Merge pull request #254 from mozilla/no-classify-on-space

Bug 1074239 - prevent classify save on spacebar
(Assignee)

Comment 6

3 years ago
Wes: I think we were going to add keyboard shortcuts for saving for accessibility purposes.  Bluring the save button moved the focus to the next button (the drop-down) and so-on.  So it got a little weird.  I think just using a keyboard shortcut to be more explicit would be preferred.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 7

2 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8b775e596d72c641ae358d7763fd1f6cb3cda33f
Bug 1074239 - prevent classify save on spacebar

https://github.com/mozilla/treeherder/commit/a59a7a34a8d9c885528dc999efc095b4dbea21de
Bug 1074239 - fix icon height on save button

https://github.com/mozilla/treeherder/commit/f66ba8bbe7a368f9985e0221e0ae83bc7dd8517c
Merge pull request #254 from mozilla/no-classify-on-space

Bug 1074239 - prevent classify save on spacebar
You need to log in before you can comment on or make changes to this bug.