Closed Bug 1074239 Opened 10 years ago Closed 10 years ago

Using space bar to add a job to the pin board occasionally just submits the classification for that job

Categories

(Tree Management :: Treeherder, defect, P1)

Product:
Tree Management
Component:
Treeherder
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KWierso, Assigned: camd)

References

Details

I don't have really good steps to reproduce this consistently, but I've been having this happen occasionally while using treeherder for sheriffing last week. I think it's some combination of manually typing something into the classification textbox on one failure, then clicking the "Save" button to submit the classification, then moving on to a new failure and pressing the space bar to add it to the pinboard. It almost seems like the "Save" button is stealing focus, so that when I press the space bar, that's simultaneously adding the new failure to the pinboard and calling the "Save" button's action against it.
I've run into this as well.
Blocks: treeherder-dev-transition
Blocks: 1059368
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #1) > I've run into this as well. Me too
Priority: -- → P1
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
ok, I can reproduce this. if the "save" button has focus, (like you tabbed to it) then clicking space will act as a click. There are probably several ways you can get focus on that, some platform specific. So I will disable "save" whn you hit spacebar.
(In reply to Cameron Dawson [:camd] from comment #3) > ok, I can reproduce this. if the "save" button has focus, (like you tabbed > to it) then clicking space will act as a click. There are probably several > ways you can get focus on that, some platform specific. So I will disable > "save" whn you hit spacebar. I think better than disabling spacebar's action when "save" is focused would be to explicitly unfocus/blur after the "save" button has been clicked or otherwise activated? Spacebar to activate a button is probably good for accessibility if it's happening intentionally.
Wes: I think we were going to add keyboard shortcuts for saving for accessibility purposes. Bluring the save button moved the focus to the next button (the drop-down) and so-on. So it got a little weird. I think just using a keyboard shortcut to be more explicit would be preferred.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.