1074271 - If after closing Loop application user looses the connectivity (no Data Connection or Server fail) the user should be able to access to it

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Pre-requisite: User registered in Loop application.

STR:
1. Close Loop application
2. Disable Data connectivity or Loop server crashes
3. Launch Loop application again

Current Result:
In case of Data lost, user is not informed about the Connectivity issue and Loop application is opened in Log-in screen.

In case of server crash it's shown "Error 401: Ooops screen" and Loop application is back to Log-in screen.

Expected Result:
We should inform the user that due to the data connection lost or the Loop server crash.

According to the Product feedback it would be great if we could inform the user and show a different message in case a data connection lost or a server crash.

It seems not feasible for 1.1 Loop version implement an offline mode as Product team suggested but, at least, we should inform to the user with the correct string. For the time being, it's fine going back to the Log-in screen as it's already implemented.

Comment 1

[Maria Angeles Oteo (:oteo)]

Pau, Monica, can you help us with these strings? Thanks a lot!

Comment 2

[Maria Angeles Oteo (:oteo)]

Thinking about it, perhaps it's not necessary this bug, when the connection is lost we go back to the log-in screen and if it there is a Data connection lost when user tries to log-in, we have already the message "Firefox Hello: Please check your internet connection” and for server crash we have already reported the Bug 1074777.

Pau, Monica, what do you think?

Comment 3

[Maria Angeles Oteo (:oteo)]

Changing the title and the expected result of this bug.
Product team suggested that the best solution would be allowing the user to access Loop application even when there is no data connection or the Loop server is out of service. For that case, no more messages will be needed, as bug 1074263 and bug 1074253 are enough to inform the user about the connectivity issues when trying to call or revoking an URL.

Jose Antonio is working a patch to implement it, if testing before landing is ok we will land it for 1.1 Loop version. In case that major regressions appear we will simply notify the user about the faults as it's explained in the description of this bug.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/158

Offline sign in support. It also allows sign in the user even if server errors occur. Would you mind to have a look please? Thanks!

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 8500735 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/158

Great job! Thanks!!

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 8500735 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/158

Removing flag due to I've found an issue.

Comment 7

[Borja Salguero [:borjasalguero]]

The error is in [1]. When the user is logged in with FxA, if no connection is found when booting Loop, watch from FxA give us a 'onerror', and we show the login panel. We need to fix that to move forward. Thanks!


[1]https://github.com/mozilla-b2g/firefoxos-loop-client/blob/master/js/controller.js#L37

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8500735 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/158

Would like you have a look at the last change I added. Find that change in the last commit of the pull request. Sorry for the noise.

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8500735 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/158

Actually this is a tiny change doesn't need to be reviewed. Carrying over r=borjasalguero then. Sorry for the noise.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/c474b54405966b7be0ea29cf0db337df848055f1