1074273 - Search entry and search results don't use same padding

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Lucas Rocha (:lucasr)]

Either add padding to search results or remove some padding from search entry?

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Comment 2

[:Margaret Leibovic]

Oh, that's because part of that padding is actually inside the WebView. We can reduce the padding above the WebView, but that may make things look bad for other search providers. Or, since we're already tweaking the CSS for this results page, perhaps we can tweak it more to get rid of this top-most padding.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #2)
> Oh, that's because part of that padding is actually inside the WebView. We
> can reduce the padding above the WebView, but that may make things look bad
> for other search providers. Or, since we're already tweaking the CSS for
> this results page, perhaps we can tweak it more to get rid of this top-most
> padding.

I meant the left and right paddings btw :-)

Comment 4

[:Margaret Leibovic]

(In reply to Lucas Rocha (:lucasr) from comment #3)
> (In reply to :Margaret Leibovic from comment #2)
> > Oh, that's because part of that padding is actually inside the WebView. We
> > can reduce the padding above the WebView, but that may make things look bad
> > for other search providers. Or, since we're already tweaking the CSS for
> > this results page, perhaps we can tweak it more to get rid of this top-most
> > padding.
> 
> I meant the left and right paddings btw :-)

Oh :)

Well the same problem exists that this is something that will vary per search provider. For example, Bing doesn't put any margin around its results. So, we could update our padding values to match Google/Yahoo (it looks like they use the same values), and then we just don't need to worry about matching if the results don't have any padding.

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Lucas Rocha (:lucasr) from comment #3)
> I meant the left and right paddings btw :-)

ah, thought you were talking about top padding hah

But yes, V1 issue that stems from using a WebView.

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Anthony Lam (:antlam) from comment #5)
> (In reply to Lucas Rocha (:lucasr) from comment #3)
> > I meant the left and right paddings btw :-)
> 
> ah, thought you were talking about top padding hah

Yeah, the top padding is separate issue. In the current UI, the web content seems to scroll off into thin air, which looks a bit weird. This can be easily solvable in the native part of the UI by simply using clipToPadding=false in the ListViews.

Margaret, shall I file a separate bug?

Comment 7

[:Margaret Leibovic]

(In reply to Lucas Rocha (:lucasr) from comment #6)
> (In reply to Anthony Lam (:antlam) from comment #5)
> > (In reply to Lucas Rocha (:lucasr) from comment #3)
> > > I meant the left and right paddings btw :-)
> > 
> > ah, thought you were talking about top padding hah
> 
> Yeah, the top padding is separate issue. In the current UI, the web content
> seems to scroll off into thin air, which looks a bit weird. This can be
> easily solvable in the native part of the UI by simply using
> clipToPadding=false in the ListViews.
> 
> Margaret, shall I file a separate bug?

Do you mean a bug for the scrolling of search history/suggestions? A separate bug about that would be good. We just unfortunately don't have much control over what the WebView content is doing.

Comment 8

[Jan Henning [:JanH]]

This is an ex-Search Activity now (bug 1221344).