1074512 - New browser window is not being shown in the Tab Manager

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Description

[Francis Djabri [:djabber]]

Steps:

1) Launch browser -> New browser window is shown
2) Tap on Tab button -> Shows tab manager view

Actual:
The New browser window is not shown in the Tab manager. 

Expected:
The new browser window should be treated as a Browser window and be shown in the Tab manager. If the user selects to load a URL, then the URL should load in the window.

Comment 1

[Francis Djabri [:djabber]]

[Blocking Requested - why for this release]: Confusing UX. There are inconsistencies between the Task manager and the Tab manager. The New browser window is shown in the Task manager but not the Tab manager. Launching browsing is a key activity and if we don't handle the New browser window well we're compromising a core part of the UX, which is that we should have browsing use cases nailed.

Comment 2

[Francis Djabri [:djabber]]

Please note, this is not a new feature, but corresponds to the Browser spec at: https://mozilla.box.com/s/3zywxvb5r0q8cqcd6314

See page 18, box 2:
"The browser windows manager displays a horizontal list of all open browser windows.

These windows should be ordered historically, with the most recent window at the
front of the list.

Note, the Browser start page should beincluded in the list of browser windows."

Comment 3

[Kevin Grandon :kgrandon]

I might give this a stab.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Here is a patch that should fix it. I'll add a simple unit test to this as well.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8497179 [details] [review]
Github pull request

Aus - could you take a look at this? Thanks!

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Pull request to v2.1

And here is a pull request to uplift should we need to.

Comment 7

[Aus Lacroix [:aus]]

Comment on attachment 8497179 [details] [review]
Github pull request

Code changes look good to me! Thanks for adding a test as well.

Comment 8

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/00d916399564df4980d60667d1988865570cc5a5

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8497183 [details] [review]
Pull request to v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Late task manager filtering work.
[User impact] if declined: Awkward UX when entering task manager from the browser app (I personally think that this should be a blocker).
[Testing completed]: Manual and unit testing.
[Risk to taking this patch] (and alternatives if risky): Low as it's sandboxed to only the filtering code in task manager.
[String changes made]: none.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Looks like the Gaia Try run has failures?

Comment 11

[Kevin Grandon :kgrandon]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> Looks like the Gaia Try run has failures?

Thanks for letting me know. I'm rebasing and trying again. These definitely look unrelated to the test though. I recall seeing other problems on v2.1 gaia-try, so I wonder if this could be some harness issue.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Yeah, they seem to be happening pretty consistently across runs.

v2.1: https://github.com/mozilla-b2g/gaia/commit/cdbbc49802357456222d34d176dc28150833be93

Comment 14

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.1 and Flame 2.2

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The new browser window page always appears in window manager.