1074603 - pl locale breaking multilocale for fennec 33.0b8

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

22:08:23 ERROR - /builds/slave/rel-m-beta-and_bld-00000000000/build/obj-firefox/mobile/android/base/res/values-pl/strings.xml:1060: error: Error parsing XML: undefined entity

Locale changes this time:
https://hg.mozilla.org/releases/l10n/mozilla-beta/pl/pushloghtml?fromchange=cce4d373d9cf&tochange=8739b46e5670

With the help of nalexander and mfinkle this change was identified as the culpit:
https://hg.mozilla.org/releases/l10n/mozilla-beta/pl/rev/ed1ec0ab8d01

Comment 1

[Rail Aliiev [:rail]]

Attachment: fix_quotes.diff

This should fix the underlying issue. The patch is against http://hg.mozilla.org/releases/l10n/mozilla-beta/pl, the error was introduced in https://hg.mozilla.org/releases/l10n/mozilla-beta/pl/rev/ed1ec0ab8d01#l1.16

Feel free to land it.

Comment 2

[Francesco Lodolo [:flod]]

This looks already fixed on mozilla-aurora with a different approach.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/fd4f12d4c50b

CCing Sarah from the Polish team too at least she's aware. Pike, should I just land the same fix on beta?

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8497252 [details] [diff] [review]
fix_quotes.diff

Review of attachment 8497252 [details] [diff] [review]:
-----------------------------------------------------------------

Doh, sorry for not catching this during reviews.

I went with a transplant of the fix that flod found on aurora, for no other reason than that that one gives me even better arguments to just land and push.

http://hg.mozilla.org/releases/l10n/mozilla-beta/pl/rev/ab067776c5a7 is in, I'll update the sign-off as soon as the dashboard picked up the change, should be 10-15 minutes.

Comment 4

[Axel Hecht [:Pike]]

... more, sorry. Didn't catch that the fix in aurora was for a changing entity, and the dashboard did catch some of that. 

Missing entities aren't always errors, but the dashboard reports a warning. Mostly because it can't really decide if the entity is really missing, or just not used in en-US, &brandShortName; vs &brandFullName; is a frequent example.

I landed another fixup, waiting for another run on the dashboard. Local compare-locales passes without warnings now, though.

Comment 5

[Axel Hecht [:Pike]]

http://hg.mozilla.org/releases/l10n/mozilla-beta/pl//rev/8eee95bff4bb landed and signed off.

Sorry for the bustage again.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Axel Hecht [:Pike] from comment #4)
> ... more, sorry. Didn't catch that the fix in aurora was for a changing
> entity, and the dashboard did catch some of that. 

Yeah, we made them change it because it was breaking a lot of stuff (bug 1048052).

Comment 7

[Rail Aliiev [:rail]]

Worked find in build2