1074772 - [Calendar] recurring all day events are not displayed for Yahoo accounts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Comment 1

[swathiks115]

Steps to reproduce.

1. Open calendar.
2. Add yahoo account.
3. Add Recurring events in PC.
  [Steps to add recurring events in PC
    * log in into yahoo account.
    * Click on any date[This will display pop-up of time slot]
    * Click on All day
    * Select ADD more details
    * Add events with Repeat Daily for 10 days
    * Save.
     ]
4. Sync yahoo account.
5. Only busy indicators are shown, events are not displayed in event list.

With the above STR events are not displayed when it is sync.If we update this events also it is not displayed.


If Recurring events are added in different way, then events are sync 
Steps to add Recurring event in another way
* log in into yahoo account.
* click on New Event [In the Top Left corner]
* Add events with Repeat Daily for 10 days
* Save
With this events are sync in calendar app.

Comment 2

[swathiks115]

Hi,
  Can you please ask someone who can look into this issue?

Thanks.

Comment 3

[Rachelle Yang [:ryang][[e-mail]]]

Hi Miller, Could you please look into the bug ? 

Thanks !

Comment 4

[Miller Medeiros [:millermedeiros]]

a few questions:

 - which build are you using? (gecko and gaia versions)
 - do you know if it only happens on 2.0, 2.1 or 2.2?
 - do you know if it's a regression?
 - is it missing on all the calendar views or just on the month view?
 - only happens for "all day" events? (was not really clear the difference between the first STR and second)

Comment 5

[Miller Medeiros [:millermedeiros]]

I was able to reproduce it on latest master. The problem happens with ANY recurring "all day event", it doesn't matter if recurrence is monthly/weekly/daily or if it was created by clicking on a given date on the yahoo calendar or by clicking the "new event" button (as STR made me think it was the case).

The problem affects all the views. One weird thing is that sometimes I'm seeing duplicate dots on the month view and/or dots on days that I'm sure there are no events.

This is the kind of bug that could take a few days to identify the root cause - maybe broken recurrence expansion? maybe some error on the way we handle all day events on the TimeSpan queries? maybe weird ICAL response from Yahoo?

PS: I was not able to reproduce this bug with my Zimbra calendar.
PPS: I was not able to test with Google calendar so far because of Bug 1067270.

---

Gaia-Rev    83de447d9ae9a59459d7a445f9348a254c661850
Gecko-Rev   https://hg.mozilla.org/mozilla-central/rev/9ee9e193fc48
Build-ID    20141007040205
Version     35.0a1

Comment 6

[Miller Medeiros [:millermedeiros]]

This issue occurs on latest 1.4, 2.0, 2.1 and 2.2 builds:

Device      Flame 1.4
Gaia-Rev    b06fee13c1d80bd2a463be1f2fb1d59169af9298
Gecko-Rev   https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/aae7c12029c2
Build-ID    20141007000200
Version     30.0

Device      Flame 2.0
Gaia-Rev    31a49c7932c7085961760a6bef9ed381ea38d7e3
Gecko-Rev   https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/4c0eb73dfac7
Build-ID    20141007000201
Version     32.0

Device      Flame 2.1
Gaia-Rev    7f738edf66b9298bceef8a4981d05d04fd04e540
Gecko-Rev   https://hg.mozilla.org/releases/mozilla-aurora/rev/b9d04c58580a
Build-ID    20141007000203
Version     34.0a2

Device      Flame 2.2 (master)
Gaia-Rev    83de447d9ae9a59459d7a445f9348a254c661850
Gecko-Rev   https://hg.mozilla.org/mozilla-central/rev/9ee9e193fc48
Build-ID    20141007040205
Version     35.0a1

Comment 7

[Miller Medeiros [:millermedeiros]]

confirmed that problem doesn't happen with Google calendars, looks like it's an Yahoo-only issue.

Comment 8

[Miller Medeiros [:millermedeiros]]

looks like problem is caused because DTSTART === DTEND:

  DTSTART;VALUE=DATE:20141009
  DTEND;VALUE=DATE:20141009
  RRULE:FREQ=WEEKLY;INTERVAL=1;BYDAY=TH

everything else looks OK. now I'm not sure if we should simply convert the DTEND to next day when that happens (consider as all day event when start === end) and/or if we should contact the Yahoo Calendar team.

Comment 9

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25041

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8503352 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25041

Only one small nit... otherwise looks great. Thanks!

Comment 11

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/8aa08e2943be43d78bcd88bfc7cb95d5a7acc79a

Comment 12

[Edward Chen[:edchen]]

Hi Miller,

The bug look likes fixed, but I found one stuff which need your confirm. When I sync recurring events from web site to mobile, all event day were shift back one day and the event time is not correctly. Could you double confirm this bug again.

[Environment]
Gaia-Rev        0dfc1996eb583c8b507a82bf6b8319624bba23ea
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/80e18ff7c7b2
Build-ID        20141029160202
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880


[Test account]
[e-mail]/5678Tyui

Comment 13

[Miller Medeiros [:millermedeiros]]

Edward, I was not able to reproduce your bug... I created an "all day" starting on Oct 30th and repeating weekly. Maybe you found a different bug.. double check your timezone on the yahoo calendar (gear icon on top right > calendar options) and also on your device - maybe there is something weird related to that.

Comment 14

[Edward Chen[:edchen]]

Okay, let me check it later with master, any update will let you know. Thanks.