1074823 - Infinite ringing if the caller cancels the call in the 'connecting' state

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Paul Silaghi, QA [:pauly]]

Canceling the call very quickly (while 'connecting') results in infinite calling on the callee side.
Note that canceling while 'ringing' works fine.

Comment 1

[u279076]

Steps:
1) User X generates a call URL and shares it with User Y
2) User Y loads the call URL and clicks "start"
3) User Y clicks "cancel" before the call can be connected

Result:
Conversation notification stays open on the callee side until they cancel/accept.

Expected:
When the caller disconnects the call, the conversation panel on the callee side should reflect that.

[Tracking Requested - why for this release]: this should probably be tracked for 35 but I'm on the fence if this should be fixed for 34 given we're soft-launching.

I can reproduce this on Mac in Nightly and Aurora so I don't think this is a regression.

Comment 2

[Mark Banner (:standard8)]

Ok, I think I know what's causing this. The websocket connection on the X side connects, and in the "hello" message on the protocol, the state is returned as "terminated".

We're not actually handling that state at all at the moment.

Comment 3

[Mark Banner (:standard8)]

Attachment: Infinite ringing if the caller cancels the call in the 'connecting' state. Handle the initial state returned from the websocket.

This fixes the issue for the link issue case - we now handle the "terminate" state from the websocket. That's the only real other state that I can see pratically happening.

For the direct calling that's partially landed, I'm currently reworking this bit of code so I'm not going to include it in this bug. I can also make it so that any state returned is handled correctly, which will serve us better in future when the code is merged.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8497779 [details] [diff] [review]
Infinite ringing if the caller cancels the call in the 'connecting' state. Handle the initial state returned from the websocket.

Review of attachment 8497779 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me; r=dmose.

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/e1afb3399612

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1afb3399612

Comment 7

[u279076]

Paul, please verify this is fixed in tomorrow's Nightly.

Comment 8

[Paul Silaghi, QA [:pauly]]

Verified fixed 35.0a1 (2014-10-02) Win 7, OS X 10.9.5, Ubuntu 13.04

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Mark - This fix has been verified on m-c. Can you please submit an Aurora uplift request?

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8497779 [details] [diff] [review]
Infinite ringing if the caller cancels the call in the 'connecting' state. Handle the initial state returned from the websocket.

Approval Request Comment
[Feature/regressing bug #]: Bug 1000237 / Bug 1067519
[User impact if declined]: On receiving an incoming call, where the caller cancels the call straight away, it was possible that the callee would have an infinitely ringing incoming call conversation. Although they could cancel or accept this, accepting wouldn't actually connect the call, and leave the user confused.
[Describe test coverage new/current, TBPL]: Landed in m-c and tested by QA. Has unit test coverage.
[Risks and why]: Low risk, change to loop code only, plus only a minor modification to an existing flow to correctly handle the information returned by the server.
[String/UUID change made/needed]: None

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e207db7a9a5a

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 OS X 10.9.5, Win 7

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8497779 [details] [diff] [review]
Infinite ringing if the caller cancels the call in the 'connecting' state. Handle the initial state returned from the websocket.

Already landed in aurora, approving for posterity