Desktop client should close the conversation window if the caller chooses to cancel the call

VERIFIED FIXED in Firefox 34

Status

Hello (Loop)
Client
--
enhancement
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla35
Points:
1
Dependency tree / graph
Bug Flags:
in-moztrap -
qe-verify +

Firefox Tracking Flags

(firefox34 verified, firefox35 verified)

Details

(Whiteboard: [loop-uplift][fig:verified])

User Story

If an incoming call is received, but then gets cancelled by the caller, we should remove the incoming conversation window from the callee's display.

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Confirmed user story with Darrin over irc.
User Story: (updated)
(Assignee)

Comment 2

3 years ago
Created attachment 8489610 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call

This closes the conversation window straight away, after doing a little tidy up. Testing out starting a call and cancelling it was annoying me that I had to close the desktop window as well ;-)
Attachment #8489610 - Flags: review?(nperriault)
(Assignee)

Updated

3 years ago
Target Milestone: --- → mozilla35
(Assignee)

Comment 3

3 years ago
Created attachment 8490045 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call v2

I've extended this version to also deal with timeouts of initial connection/ringing but not the timeout after the call is accepted, as that needs to be handled in other bugs.
Attachment #8489610 - Attachment is obsolete: true
Attachment #8489610 - Flags: review?(nperriault)
Attachment #8490045 - Flags: review?(nperriault)
(Assignee)

Comment 4

3 years ago
Created attachment 8490065 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call. v3

Updated patch with paired review comments.
Attachment #8490045 - Attachment is obsolete: true
Attachment #8490045 - Flags: review?(nperriault)
Attachment #8490065 - Flags: review?(nperriault)
Comment on attachment 8490065 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call. v3

Review of attachment 8490065 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8490065 - Flags: review?(nperriault) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/93a2036a377e
https://hg.mozilla.org/mozilla-central/rev/93a2036a377e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
I'm not sure if this is working correctly.

1. Click the Firefox Hello toolbar button
2. Copy the URL and open it in a new tab
3. Click the "start" button
> Converstation Request appears
4. On the Standalone page, click the "exit" button
> Call ends in the Standalone UI
> Conversation Request remains open

I'm on today's Nightly (2014-09-17). Am I testing this wrong?
Flags: qe-verify+
(Assignee)

Comment 9

3 years ago
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #8)
> I'm on today's Nightly (2014-09-17). Am I testing this wrong?

Bug 1000237 hasn't been deployed to the production loop-client server yet (waiting on the current server release), so you need to use the dev server to see the combined effects, set loop.server to:

https://loop-dev.stage.mozaws.net

No trailing slash.

Note that if you change the pref, you'll invalidate any urls previously generated even if you switch the preference back again.
Whiteboard: [loop-uplift]
Verified fixed 35.0a1 (2014-09-21) Win 7, OS X 10.9.5, Ubuntu 12.10
Status: RESOLVED → VERIFIED
status-firefox35: --- → verified
Shouldn't we have a notification for this on the callee side?
Also, bug 1022594 no longer applies - no message is seen when the callee declines the call.
Flags: needinfo?(standard8)
(Assignee)

Comment 12

3 years ago
(In reply to Paul Silaghi, QA [:pauly] from comment #11)
> Shouldn't we have a notification for this on the callee side?

We don't have any UX specified currently. Its arguable that we should get "Missed calls" notifications later on.

> Also, bug 1022594 no longer applies - no message is seen when the callee
> declines the call.

That should get fixed by bug 1000240.
Flags: needinfo?(standard8)
Paul can you please test this again across platforms using the following Try-server build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rjesup@wgate.com-f9eb2cbac352
Flags: needinfo?(paul.silaghi)
QA Contact: anthony.s.hughes → paul.silaghi
Whiteboard: [loop-uplift] → [loop-uplift][fig:verifyme]
Actually this is not entirely fixed.
Canceling the call very quickly (while 'connecting') results in infinite calling on the callee side.
Note that canceling while 'ringing' works fine.
Status: VERIFIED → REOPENED
Flags: needinfo?(paul.silaghi)
Resolution: FIXED → ---
(In reply to Paul Silaghi, QA [:pauly] from comment #14)
> Actually this is not entirely fixed.
> Canceling the call very quickly (while 'connecting') results in infinite
> calling on the callee side.
> Note that canceling while 'ringing' works fine.

Pauly -- I think it would be clearer/better to open up a new bug for this problem.  You've found an edge case bug (likely a race condition), perhaps involving the server.
Flags: needinfo?(paul.silaghi)
Depends on: 1074823
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #15)
> Pauly -- I think it would be clearer/better to open up a new bug for this
> problem
bug 1074823
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Flags: needinfo?(paul.silaghi)
Resolution: --- → FIXED
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #13)
> Paul can you please test this again across platforms using the following
> Try-server build?
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rjesup@wgate.com-
> f9eb2cbac352
Verified fixed in the "ringing" state on Win 7, Ubuntu 13.04, OS X 10.9.5
Status: RESOLVED → VERIFIED
Whiteboard: [loop-uplift][fig:verifyme] → [loop-uplift][fig:verified]
Comment on attachment 8490065 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call. v3

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8490065 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-aurora/rev/59a9099979f8

Updated

3 years ago
status-firefox34: --- → verified
Comment on attachment 8490065 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call. v3

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8490065 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.