1067519 - Desktop client should close the conversation window if the caller chooses to cancel the call

Status: VERIFIED FIXED

(Hello (Loop) :: Client, enhancement)

Comment 1

[Mark Banner (:standard8)]

Confirmed user story with Darrin over irc.

Comment 2

[Mark Banner (:standard8)]

Attachment: Loop desktop client should close the conversation window if the caller chooses to cancel the call

This closes the conversation window straight away, after doing a little tidy up. Testing out starting a call and cancelling it was annoying me that I had to close the desktop window as well ;-)

Comment 3

[Mark Banner (:standard8)]

Attachment: Loop desktop client should close the conversation window if the caller chooses to cancel the call v2

I've extended this version to also deal with timeouts of initial connection/ringing but not the timeout after the call is accepted, as that needs to be handled in other bugs.

Comment 4

[Mark Banner (:standard8)]

Attachment: Loop desktop client should close the conversation window if the caller chooses to cancel the call. v3

Updated patch with paired review comments.

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8490065 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call. v3

Review of attachment 8490065 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/93a2036a377e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/93a2036a377e

Comment 8

[u279076]

I'm not sure if this is working correctly.

1. Click the Firefox Hello toolbar button
2. Copy the URL and open it in a new tab
3. Click the "start" button
> Converstation Request appears
4. On the Standalone page, click the "exit" button
> Call ends in the Standalone UI
> Conversation Request remains open

I'm on today's Nightly (2014-09-17). Am I testing this wrong?

Comment 9

[Mark Banner (:standard8)]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #8)
> I'm on today's Nightly (2014-09-17). Am I testing this wrong?

Bug 1000237 hasn't been deployed to the production loop-client server yet (waiting on the current server release), so you need to use the dev server to see the combined effects, set loop.server to:

https://loop-dev.stage.mozaws.net

No trailing slash.

Note that if you change the pref, you'll invalidate any urls previously generated even if you switch the preference back again.

Comment 10

[Paul Silaghi, QA [:pauly]]

Verified fixed 35.0a1 (2014-09-21) Win 7, OS X 10.9.5, Ubuntu 12.10

Comment 11

[Paul Silaghi, QA [:pauly]]

Shouldn't we have a notification for this on the callee side?
Also, bug 1022594 no longer applies - no message is seen when the callee declines the call.

Comment 12

[Mark Banner (:standard8)]

(In reply to Paul Silaghi, QA [:pauly] from comment #11)
> Shouldn't we have a notification for this on the callee side?

We don't have any UX specified currently. Its arguable that we should get "Missed calls" notifications later on.

> Also, bug 1022594 no longer applies - no message is seen when the callee
> declines the call.

That should get fixed by bug 1000240.

Comment 13

[u279076]

Paul can you please test this again across platforms using the following Try-server build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f9eb2cbac352

Comment 14

[Paul Silaghi, QA [:pauly]]

Actually this is not entirely fixed.
Canceling the call very quickly (while 'connecting') results in infinite calling on the callee side.
Note that canceling while 'ringing' works fine.

Comment 15

[Maire Reavy [:mreavy]]

(In reply to Paul Silaghi, QA [:pauly] from comment #14)
> Actually this is not entirely fixed.
> Canceling the call very quickly (while 'connecting') results in infinite
> calling on the callee side.
> Note that canceling while 'ringing' works fine.

Pauly -- I think it would be clearer/better to open up a new bug for this problem.  You've found an edge case bug (likely a race condition), perhaps involving the server.

Comment 16

[Paul Silaghi, QA [:pauly]]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #15)
> Pauly -- I think it would be clearer/better to open up a new bug for this
> problem
bug 1074823

Comment 17

[Paul Silaghi, QA [:pauly]]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #13)
> Paul can you please test this again across platforms using the following
> Try-server build?
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-
> f9eb2cbac352
Verified fixed in the "ringing" state on Win 7, Ubuntu 13.04, OS X 10.9.5

Comment 18

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8490065 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call. v3

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 19

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/59a9099979f8

Comment 20

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8490065 [details] [diff] [review]
Loop desktop client should close the conversation window if the caller chooses to cancel the call. v3

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.